Re: Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-28 Thread Chao Li
Hi Peter, Thank you so much for your help. > On Aug 29, 2025, at 13:42, Peter Eisentraut wrote: > > This patch still causes a compiler warning: > > ../src/backend/storage/lmgr/lmgr.c: In function 'XactLockTableWait': > ../src/backend/storage/lmgr/lmgr.c:681:27: error: assignment discards 'cons

Re: Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-28 Thread Peter Eisentraut
On 28.08.25 04:27, Chao Li wrote: On Aug 27, 2025, at 17:24, Peter Eisentraut wrote: This style of having Foo be a type alias for pointer-to-FooData is an ancient Postgres coding convention that does not map well to modern C that has an emphasis on judicious use of qualifiers and attributes,

Re: Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-27 Thread Chao Li
Mail Archive always misses attachments sent by Apple Mail. Resending from the Gmail web client. Chao Li (Evan) - Highgo Software Co., Ltd. https://www.highgo.com/ Chao Li 于2025年8月28日周四 10:28写道: > > > On Aug 27, 2025, at 17:24, Peter Eisentraut wrote: > > This style of havi

Re: Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-27 Thread Chao Li
On Aug 27, 2025, at 17:24, Peter Eisentraut wrote:This style of having Foo be a type alias for pointer-to-FooData is an ancient Postgres coding convention that does not map well to modern C that has an emphasis on judicious use of qualifiers and attributes, and so if this abstraction gets in the w

Re: Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-27 Thread Peter Eisentraut
On 27.08.25 10:57, Chao Li wrote: This is a pure refactor patch. The functions LockTuple, ConditionalLockTuple, UnlockTuple, and XactLockTableWait take an ItemPointer parameter named 'tid'. Since these functions do not modify the tuple identifier, the parameter should be declared as const to

Mark ItemPointer parameters as const in tuple/table lock functions

2025-08-27 Thread Chao Li
Hi Hackers, This is a pure refactor patch. The functions LockTuple, ConditionalLockTuple, UnlockTuple, and XactLockTableWait take an ItemPointer parameter named 'tid'. Since these functions do not modify the tuple identifier, the parameter should be declared as const to better convey intent and a