Re: Mingw task for Cirrus CI

Hi, On 2022-10-24 14:13:06 +0300, Melih Mutlu wrote: > If you say so, then I think it's ready. I pushed it with a few changes: - I added an only_if, otherwise the task shows up (without running) even if you use ci-os-only: linux - I added -Dnls=disabled - It seemed to add about 1.5min to the c

Re: Mingw task for Cirrus CI

Hi, > > + > > + on_failure: > > +<<: *on_failure_meson > > +cores_script: | > > + %BASH_EXE% -lc "cd build src/tools/ci/cores_backtrace.sh msys > build/tmp_install" > > + > > This is wrong - it should just archive the same files that the current > windows > task does. > Changed it

Re: Mingw task for Cirrus CI

Hi, On 2022-10-19 17:59:22 +0300, Melih Mutlu wrote: > All the things you mentioned above are done. > Then I should increase CCACHE_MAXSIZE, right? Made it 500MB for MinGW. Yes. > + > + on_failure: > +<<: *on_failure_meson > +cores_script: | > + %BASH_EXE% -lc "cd build src/tools/

Re: Mingw task for Cirrus CI

Hi, Andres Freund , 19 Eki 2022 Çar, 06:19 tarihinde şunu yazdı: > It's a bit odd to separate the CCACHE_* variables from each other > (e.g. BUILD_DIR is inbetween them)... > > Perhaps add a comment explaining that otherwise plpython tests fail? > With this src/tools/ci/cores_backtrace.sh shoul

Re: Mingw task for Cirrus CI

Hi, On 2022-10-19 00:23:46 +0300, Melih Mutlu wrote: > Right, setting CHERE_INVOKING and removing all cd's work and look better. > Thanks for the suggestion. Agreed, good idea. > + > + env: > +CCACHE_DIR: C:/msys64/ccache It's a bit odd to separate the CCACHE_* variables from each other

Re: Mingw task for Cirrus CI

Hi Bilal, Nazir Bilal Yavuz , 18 Eki 2022 Sal, 15:37 tarihinde şunu yazdı: > env: > ... > CHERE_INVOKING: 1 > BASH_EXE: C:\msys64\usr\bin\bash.exe > > 'CHERE_INVOKING: 1' will cause bash.exe to start from current working > directory(%CIRRUS_WORKING_DIR%). > > In this way, there is no

Re: Mingw task for Cirrus CI

Hi, Thanks for the patch! On 10/18/22 12:49, Melih Mutlu wrote: You can find the updated patch attached. Does it makes sense to set these at 'Windows - Server 2019, MinGW64 - Meson' task: env:     ...     CHERE_INVOKING: 1     BASH_EXE: C:\msys64\usr\bin\bash.exe 'CHERE_INVOKING: 1' wi

Re: Mingw task for Cirrus CI

Hi Andres, Andres Freund , 11 Eki 2022 Sal, 21:23 tarihinde şunu yazdı: > I think it might be easier to just set MSYS=winjitdebug > > https://www.msys2.org/wiki/JIT-Debugging/#native-windows-processes-started-from-msys2 > and then rely on the existing windows crash reporting stuff. > Done. > Y

Re: Mingw task for Cirrus CI

Hi, On 2022-10-11 11:23:36 -0700, Andres Freund wrote: > > + build_script: > > +- C:\msys64\usr\bin\dash.exe -lc "cd %CIRRUS_WORKING_DIR% && ninja -C > > %BUILD_DIR%" > > + upload_caches: ccache Only remembered that just after sending my email: When using b_pch=true (which saves a lot of t

Re: Mingw task for Cirrus CI

Hi, On 2022-10-07 20:00:56 +0300, Melih Mutlu wrote: > Attached patch is the adjusted version to build with meson. Thanks! > diff --git a/.cirrus.yml b/.cirrus.yml > index 9f2282471a..7e6ebdf7b7 100644 > --- a/.cirrus.yml > +++ b/.cirrus.yml > @@ -35,6 +35,7 @@ on_failure_ac: &on_failure_ac >

Re: Mingw task for Cirrus CI

Hi hackers. Andres Freund , 22 Eyl 2022 Per, 20:03 tarihinde şunu yazdı: > Now that meson has been merged, could you try to adjust this patch so it > builds with meson? > Attached patch is the adjusted version to build with meson. Add a commented-out trigger-type: manual and note in the commit

Re: Mingw task for Cirrus CI

Hi Melih, On 2022-09-05 16:52:17 -0700, Andres Freund wrote: > I think we can convert this to meson soon, and that seems a *lot* faster at > configure than autoconf on mingw. Not even close to as fast as on a modern-ish > linux, but not that painful. Now that meson has been merged, could you try

Re: Mingw task for Cirrus CI

Hi, On 2022-09-21 16:18:43 +0300, Melih Mutlu wrote: > I've been thinking about how to make the mingw task run only for this patch > on cfbot and not for others. TBH, I couldn't come up with a nice way to > achieve this. > > Does anyone have any suggestions on this? Add a commented-out trigger-t

Re: Mingw task for Cirrus CI

Hi hackers, Justin Pryzby , 5 Eyl 2022 Pzt, 14:50 tarihinde şunu yazdı: > But cfbot should run the Mingw task for this patch's own commitfest > entry. But right now (because cfbot doesn't include the original commit > message/s), it doesn't get run :( > I've been thinking about how to make the

Re: Mingw task for Cirrus CI

On Mon, Sep 05, 2022 at 04:52:17PM -0700, Andres Freund wrote: > I don't think you should need to use --host, that indicates cross compiling, This made me consider the idea of cross-compiling for windows under a new linux task, and then running tests under Windows with a dependent task. I suppose

Re: Mingw task for Cirrus CI

Hi, On 2022-09-05 06:50:55 -0500, Justin Pryzby wrote: > I saw that but hadn't tracked it down yet. Do you know if the tar > failures were from a TAP test added since you first posted the mingw > patch, or ?? I think it's that msys now includes tar by default, but not sure. > Also: your origin

Re: Mingw task for Cirrus CI

On Sat, Sep 03, 2022 at 12:52:54AM +0300, Melih Mutlu wrote: > Justin Pryzby , 19 Ağu 2022 Cum, 05:34 tarihinde şunu > yazdı: > > > Inline notes about changes since the last version. > > > > On Thu, Jul 28, 2022 at 05:44:28PM -0500, Justin Pryzby wrote: > > > I think the "only_if" should allow se

Re: Mingw task for Cirrus CI

Justin Pryzby , 19 Ağu 2022 Cum, 05:34 tarihinde şunu yazdı: > Inline notes about changes since the last version. > > On Thu, Jul 28, 2022 at 05:44:28PM -0500, Justin Pryzby wrote: > > I think the "only_if" should allow separately running one but not both > of the > > windows instances, like: > >

Re: Mingw task for Cirrus CI

Inline notes about changes since the last version. On Thu, Jul 28, 2022 at 05:44:28PM -0500, Justin Pryzby wrote: > I think the "only_if" should allow separately running one but not both of the > windows instances, like: > > + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || > $CIRRUS

Re: Mingw task for Cirrus CI

On Thu, Aug 4, 2022 at 2:04 PM Thomas Munro wrote: > I noticed that this says: > > [01:01:45.657] sqlda.pgc: In function 'dump_sqlda': > [01:01:45.657] sqlda.pgc:45:33: warning: format '%d' expects argument > of type 'int', but argument 3 has type 'long long int' [-Wformat=] > [01:01:45.657] 45 |

Re: Mingw task for Cirrus CI

I noticed that this says: [01:01:45.657] sqlda.pgc: In function 'dump_sqlda': [01:01:45.657] sqlda.pgc:45:33: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long long int' [-Wformat=] [01:01:45.657] 45 | "name sqlda descriptor: '%s' value %I64d\n", [01:01:45.657] | ^

Re: Mingw task for Cirrus CI

I think the "only_if" should allow separately running one but not both of the windows instances, like: + only_if: $CIRRUS_CHANGE_MESSAGE !=~ '.*\nci-os-only:.*' || $CIRRUS_CHANGE_MESSAGE =~ '.*\nci-os-only:[^\n]*mingw64' I'm not sure, but maybe this task should only run "by request", and omit t

Re: Mingw task for Cirrus CI

Hi hackers, I'm sharing the rebased version of this patch, if you're still interested. I would appreciate any feedback or concerns. Best, Melih Andrew Dunstan , 9 Nis 2022 Cmt, 19:34 tarihinde şunu yazdı: > > On 4/8/22 21:02, Andres Freund wrote: > > Hi, > > > > On 2022-04-08 19:27:58 -0500,

Re: Mingw task for Cirrus CI

On 4/8/22 21:02, Andres Freund wrote: > Hi, > > On 2022-04-08 19:27:58 -0500, Justin Pryzby wrote: >> On Thu, Apr 07, 2022 at 10:10:21AM -0700, Andres Freund wrote: >>> On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote: On 3/30/22 20:26, Andres Freund wrote: > Could you try using dash t

Re: Mingw task for Cirrus CI

On 2022-Apr-08, Andres Freund wrote: > I just realized that the second find is pretty expensive compared to the > first. > > time find "$sourcetree" -type d \( \( -name CVS -prune \) -o \( -name .git > -prune \) -o -print \) | grep -v "$sourcetree/doc/src/sgml/\+" > /dev/null > real 0m0.019s >

Re: Mingw task for Cirrus CI

Hi, On 2022-04-08 19:27:58 -0500, Justin Pryzby wrote: > On Thu, Apr 07, 2022 at 10:10:21AM -0700, Andres Freund wrote: > > On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote: > > > On 3/30/22 20:26, Andres Freund wrote: > > > > Could you try using dash to invoke configure here, and whether it mak

Re: Mingw task for Cirrus CI

On Thu, Apr 07, 2022 at 10:10:21AM -0700, Andres Freund wrote: > Hi, > > On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote: > > On 3/30/22 20:26, Andres Freund wrote: > > > Could you try using dash to invoke configure here, and whether it makes > > > configure faster? > > I got weird failures re

Re: Mingw task for Cirrus CI

Hi, On 2022-04-08 17:04:34 +0200, Alvaro Herrera wrote: > > Since dash won't help us to get the build time down sufficiently, and the > > tests don't pass without a separate build tree, I looked at what makes > > config/prep_buildtree so slow. > > Maybe we can replace prep_buildtree with a Perl sc

Re: Mingw task for Cirrus CI

> On windows that makes prep_buildtree go from 42.4s to 5.8s for me. > I applied Andres's faster prep build tree changes and triggered some cirrus runs Without these changes, preparing build tree was taking around 42.3s (sometimes even more) [1] It seems like with these changes it drops to around

Re: Mingw task for Cirrus CI

On 2022-Apr-07, Andres Freund wrote: > Since dash won't help us to get the build time down sufficiently, and the > tests don't pass without a separate build tree, I looked at what makes > config/prep_buildtree so slow. Maybe we can replace prep_buildtree with a Perl script. Surely that should be

Re: Mingw task for Cirrus CI

Hi Andrew, You should set MSYSTEM=UCRT64 in the environment section. Given that, > there should be no need to specify a --host= setting for configure. > It's set to UCRT64 in the docker image side [1]. I didn't know --host isn't necessary on UCRT64 environment. I'll remove it then. [1] https:

Re: Mingw task for Cirrus CI

On 4/7/22 16:48, Andrew Dunstan wrote: > On 4/7/22 13:10, Andres Freund wrote: >> Hi, >> >> On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote: >>> On 3/30/22 20:26, Andres Freund wrote: Could you try using dash to invoke configure here, and whether it makes configure faster? >>> I got

Re: Mingw task for Cirrus CI

On 4/7/22 13:10, Andres Freund wrote: > Hi, > > On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote: >> On 3/30/22 20:26, Andres Freund wrote: >>> Could you try using dash to invoke configure here, and whether it makes >>> configure faster? >> I got weird failures re libxml/parser.h when I tried

Re: Mingw task for Cirrus CI

On 4/6/22 12:34, Andres Freund wrote: > Hi, > > On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote: >> On 3/30/22 20:26, Andres Freund wrote: >>> Could you try using dash to invoke configure here, and whether it makes >>> configure faster? >> I got weird failures re libxml/parser.h when I tried

Re: Mingw task for Cirrus CI

Hi, On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote: > On 3/30/22 20:26, Andres Freund wrote: > > Could you try using dash to invoke configure here, and whether it makes > > configure faster? > I got weird failures re libxml/parser.h when I tried with dash. See >

Re: Mingw task for Cirrus CI

Hi, On 2022-04-06 11:03:37 -0400, Andrew Dunstan wrote: > On 3/30/22 20:26, Andres Freund wrote: > > Could you try using dash to invoke configure here, and whether it makes > > configure faster? > I got weird failures re libxml/parser.h when I tried with dash. Hm. Hadn't enabled that when I trie

Re: Mingw task for Cirrus CI

On 3/30/22 20:26, Andres Freund wrote: > Could you try using dash to invoke configure here, and whether it makes > configure faster? > > I got weird failures re libxml/parser.h when I tried with dash. See (It would be nice if we could see config.lo

Re: Mingw task for Cirrus CI

On 4/4/22 16:41, Andres Freund wrote: > Hi, > > On 2022-03-30 17:26:18 -0700, Andres Freund wrote: >> Hi, >> >> On 2022-03-22 19:00:42 +0300, Melih Mutlu wrote: >>> Rebased it. >>> I also removed the temp installation task and >>> used NoDefaultCurrentDirectoryInExePath env variable instead. >> H

Re: Mingw task for Cirrus CI

Hi, On 2022-03-30 17:26:18 -0700, Andres Freund wrote: > Hi, > > On 2022-03-22 19:00:42 +0300, Melih Mutlu wrote: > > Rebased it. > > I also removed the temp installation task and > > used NoDefaultCurrentDirectoryInExePath env variable instead. > > Hm. But you're still using a separate build dire

Re: Mingw task for Cirrus CI

Hi, On 2022-03-22 19:00:42 +0300, Melih Mutlu wrote: > Rebased it. > I also removed the temp installation task and > used NoDefaultCurrentDirectoryInExePath env variable instead. Hm. But you're still using a separate build directory, from what I can see? The NoDefaultCurrentDirectoryInExePath thi

Re: Mingw task for Cirrus CI

Hi Andres, Rebased it. I also removed the temp installation task and used NoDefaultCurrentDirectoryInExePath env variable instead. Best, Melih From e8a1dae0ec10efd8a967070e0d412d2bf875fa93 Mon Sep 17 00:00:00 2001 From: Melih Mutlu Date: Mon, 21 Feb 2022 14:46:05 +0300 Subject: [PATCH] Added Win

Re: Mingw task for Cirrus CI

Hi, On 2022-02-25 19:44:27 +0300, Melih Mutlu wrote: > I've been working on adding Windows+MinGW environment into cirrus-ci tasks > (discussion about ci is here [1]). This doesn't apply anymore: http://cfbot.cputube.org/patch_37_3575.log Could you rebase? Greetings, Andres Freund

Re: Mingw task for Cirrus CI

On 3/3/22 05:16, Melih Mutlu wrote: > Hi Andres,  >   > > This presumably is due to using mingw's python rather than > python.org 's > python. Seems like a reasonable thing to support for the mingw build. > > Melih, you could try to build against the python.org

Re: Mingw task for Cirrus CI

Hi Andres, > This presumably is due to using mingw's python rather than python.org's > python. Seems like a reasonable thing to support for the mingw build. > > Melih, you could try to build against the python.org python (i installed > in > the CI container). > I tried to use the installed pytho

Re: Mingw task for Cirrus CI

On 2/25/22 19:27, Andres Freund wrote: > Hi, > > Andrew, CCIng you both because you might be interested in the CI bit, and > because you might know the answer. > > > >> 2- src/pl/plpython/Makefile looks under "C:/Windows/system32/" for >> PYTHONDLL. gendef cannot open that file, give an error li

Re: Mingw task for Cirrus CI

Hi, Andrew, CCIng you both because you might be interested in the CI bit, and because you might know the answer. On 2022-02-25 19:44:27 +0300, Melih Mutlu wrote: > I've been working on adding Windows+MinGW environment into cirrus-ci tasks > (discussion about ci is here [1]). > It uses MSYS2 to se

Mingw task for Cirrus CI

Hi All, I've been working on adding Windows+MinGW environment into cirrus-ci tasks (discussion about ci is here [1]). It uses MSYS2 to set the environment. UCRT is chosen as C standard library, instead of MSVCRT. The task configures postgres with features that are available in MSYS2 (see available