Re: Minor meson gripe

2023-02-09 Thread Peter Geoghegan
On Thu, Feb 9, 2023 at 5:17 PM Andres Freund wrote: > I've seen more failures than I'd like. Permission errors, conflicting names, > and similar things. But mainly that was a reference to running initdb, which > I've broken temporarily many a time. We've all temporarily broken initdb literally th

Re: Minor meson gripe

2023-02-09 Thread Andres Freund
Hi, On 2023-02-09 17:00:48 -0800, Peter Geoghegan wrote: > On Thu, Feb 9, 2023 at 4:33 PM Andres Freund wrote: > > I e.g. have a not-quite-done patch that creates a "template initdb", which > > pg_regress and tap tests automatically use (except if non-default options > > are > > required), which

Re: Minor meson gripe

2023-02-09 Thread Peter Geoghegan
On Thu, Feb 9, 2023 at 4:33 PM Andres Freund wrote: > The individual test is actually named tmp_install. I thought it might be > useful to add further things to the setup "stage", hence the more general > name. I did notice that, but only after sitting with my initial confusion for a while. > I

Re: Minor meson gripe

2023-02-09 Thread Andres Freund
Hi, On 2023-02-09 15:34:34 -0800, Peter Geoghegan wrote: > Why not change the suite name to tmp_install? That immediately reminds > me of what's really going on here, since I'm used to seeing that > directory name. And it clashes with "--suite setup" in a way that > seems useful. The individual t

Re: Minor meson gripe

2023-02-09 Thread Peter Geoghegan
On Thu, Feb 9, 2023 at 12:56 PM Andres Freund wrote: > > * Isn't it confusing that we have a suite by that name, given that we > > also need to use the unrelated --setup flag for some nearby testing > > recipes? > > Hm. I don't find it particularly confusing, but I don't think I'm a good judge > o

Re: Minor meson gripe

2023-02-09 Thread Andres Freund
Hi, On 2023-02-09 11:01:31 -0800, Peter Geoghegan wrote: > Currently, meson has a test suite named "setup". According to the > Wiki, this is needed to get something equivalent to "make check", by > running "meson test -v --suite setup --suite regress". Yep. > Some questions about this: > > * Is

Minor meson gripe

2023-02-09 Thread Peter Geoghegan
Currently, meson has a test suite named "setup". According to the Wiki, this is needed to get something equivalent to "make check", by running "meson test -v --suite setup --suite regress". Some questions about this: * Isn't it confusing that we have a suite by that name, given that we also need