Re: Misleading panic message in backend/access/transam/xlog.c

2019-01-11 Thread Robert Haas
On Wed, Jan 9, 2019 at 8:38 PM Michael Paquier wrote: > On Wed, Jan 09, 2019 at 05:09:19PM -0800, Andres Freund wrote: > > IIRC we have other such errors including offset and length (and if > > not we'll grow some). It should be formatted as a genetic write > > error with the file name, no referen

Re: Misleading panic message in backend/access/transam/xlog.c

2019-01-09 Thread Michael Paquier
On Wed, Jan 09, 2019 at 05:09:19PM -0800, Andres Freund wrote: > IIRC we have other such errors including offset and length (and if > not we'll grow some). It should be formatted as a genetic write > error with the file name, no reference to log file, etc, even if > there's no precedent. Yeah, th

Re: Misleading panic message in backend/access/transam/xlog.c

2019-01-09 Thread Andres Freund
On January 9, 2019 5:01:40 PM PST, Michael Paquier wrote: >On Wed, Jan 09, 2019 at 08:10:43AM -0800, Andres Freund wrote: >> I'm quite unenthused about that. If anything, I'd remove detail and >use >> the standard error message about not being able to write to a file, >and >> include the full p

Re: Misleading panic message in backend/access/transam/xlog.c

2019-01-09 Thread Michael Paquier
On Wed, Jan 09, 2019 at 08:10:43AM -0800, Andres Freund wrote: > I'm quite unenthused about that. If anything, I'd remove detail and use > the standard error message about not being able to write to a file, and > include the full path. Partially agreed. Those messages have been left out of 56df07

Re: Misleading panic message in backend/access/transam/xlog.c

2019-01-09 Thread Andres Freund
Hi, On 2019-01-09 12:06:39 +0100, Michael Banck wrote: > there was a report in #postgresql recently about a crash on Google Cloud > SQL with the somewhat misleading message "could not write to log file" > while in fact it was the xlog/wal: > > |PANIC: could not write to log file 00010196

Re: Misleading panic message in backend/access/transam/xlog.c

2019-01-09 Thread Magnus Hagander
On Wed, Jan 9, 2019 at 12:06 PM Michael Banck wrote: > Hi, > > there was a report in #postgresql recently about a crash on Google Cloud > SQL with the somewhat misleading message "could not write to log file" > while in fact it was the xlog/wal: > > |PANIC: could not write to log file 000100

Misleading panic message in backend/access/transam/xlog.c

2019-01-09 Thread Michael Banck
Hi, there was a report in #postgresql recently about a crash on Google Cloud SQL with the somewhat misleading message "could not write to log file" while in fact it was the xlog/wal: |PANIC: could not write to log file 000101960054 at offset | 13279232, length 245760: Cannot allocate