Re: Missing llvm_leave_fatal_on_oom() call

2023-07-05 Thread Heikki Linnakangas
On 04/07/2023 19:33, Daniel Gustafsson wrote: On 21 Feb 2023, at 15:50, Heikki Linnakangas wrote: llvm_release_context() calls llvm_enter_fatal_on_oom(), but it never calls llvm_leave_fatal_on_oom(). Isn't that a clear leak? Not sure how much of a leak it is since IIUC LLVM just stores a fun

Re: Missing llvm_leave_fatal_on_oom() call

2023-07-04 Thread Daniel Gustafsson
> On 21 Feb 2023, at 15:50, Heikki Linnakangas wrote: > > llvm_release_context() calls llvm_enter_fatal_on_oom(), but it never calls > llvm_leave_fatal_on_oom(). Isn't that a clear leak? Not sure how much of a leak it is since IIUC LLVM just stores a function pointer to our error handler, but I

Missing llvm_leave_fatal_on_oom() call

2023-02-21 Thread Heikki Linnakangas
llvm_release_context() calls llvm_enter_fatal_on_oom(), but it never calls llvm_leave_fatal_on_oom(). Isn't that a clear leak? (spotted this while investigating https://www.postgresql.org/message-id/a53cacb0-8835-57d6-31e4-4c5ef196d...@deepbluecap.com, but it seems unrelated) - Heikkidiff --