Re: New gist vacuum.

2018-03-02 Thread Andrey Borodin
> 2 марта 2018 г., в 21:25, Tom Lane написал(а): > > Andrey Borodin writes: >> So, I agree, unconditional counting is a good idea. Here's the v3 patch. > > Pushed with trivial cosmetic adjustments. > > I've marked the CF entry as committed; please make a new CF entry in > 2018-09 for the oth

Re: New gist vacuum.

2018-03-02 Thread Tom Lane
Andrey Borodin writes: > So, I agree, unconditional counting is a good idea. Here's the v3 patch. Pushed with trivial cosmetic adjustments. I've marked the CF entry as committed; please make a new CF entry in 2018-09 for the other patch. I'd also suggest starting a new email thread for that. L

Re: New gist vacuum.

2018-03-01 Thread Andrey Borodin
> 1 марта 2018 г., в 22:44, Tom Lane написал(а): > > Michail Nikolaev writes: >> I have added small change to patch to allow it be compiled using msvc >> (uint64_t -> uint64). >> Everything seems to work, check-world is passing. > >> Actually patch fixes two issues: >> 1) Partial GIST indexe

Re: New gist vacuum.

2018-03-01 Thread Tom Lane
Michail Nikolaev writes: > I have added small change to patch to allow it be compiled using msvc > (uint64_t -> uint64). > Everything seems to work, check-world is passing. > Actually patch fixes two issues: > 1) Partial GIST indexes now have corrent tuples count estimation. > 2) Now subsequent

Re: New gist vacuum.

2018-02-25 Thread Michail Nikolaev
> I'll attach patch file next message. Updated patch is attached. gist-vacuum-count.patch Description: Binary data

Re: New gist vacuum.

2018-02-25 Thread Michail Nikolaev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested Hello. I have added small change to patch to allow it be compiled us

Re: New gist vacuum.

2018-02-08 Thread David Steele
Hi Andrey, On 2/7/18 10:46 AM, Andrey Borodin wrote: >> 7 февр. 2018 г., в 18:39, David Steele написал(а): >> >> Hi Andrey, >> >> On 1/21/18 5:34 AM, Andrey Borodin wrote: >>> Hello, Alexander! 16 янв. 2018 г., в 21:42, Andrey Borodin написал(а): Please find README patch attached. >>>

Re: New gist vacuum.

2018-02-07 Thread Andrey Borodin
Hi, David! > 7 февр. 2018 г., в 18:39, David Steele написал(а): > > Hi Andrey, > > On 1/21/18 5:34 AM, Andrey Borodin wrote: >> Hello, Alexander! >>> 16 янв. 2018 г., в 21:42, Andrey Borodin написал(а): >>> Please find README patch attached. >> >> Here's v2 version. Same code, but x2 comments

Re: Re: New gist vacuum.

2018-02-07 Thread David Steele
Hi Andrey, On 1/21/18 5:34 AM, Andrey Borodin wrote: > Hello, Alexander! >> 16 янв. 2018 г., в 21:42, Andrey Borodin написал(а): >> Please find README patch attached. > > Here's v2 version. Same code, but x2 comments. Also fixed important typo in > readme BFS->DFS. Feel free to ping me any time

Re: New gist vacuum.

2018-01-21 Thread Andrey Borodin
0001-Delete-pages-during-GiST-VACUUM-v2.patch Description: Binary data 0002-Physical-GiSC-scan-during-VACUUM-v2.patch Description: Binary data 0003-Update-README-with-info-on-new-GiST-VACUUM-v2.patch Description: Binary data

Re: New gist vacuum.

2018-01-16 Thread Andrey Borodin
Hi! > 15 янв. 2018 г., в 23:42, Alexander Korotkov > написал(а): > > I'm very glad this patch isn't forgotten. I've assigned to review this patch. Cool, thanks! > My first note on this patchset is following. These patches touches sensitive > aspects or GiST and are related to complex concurre

Re: New gist vacuum.

2018-01-15 Thread Andrey Borodin
Hi, Alexander! Many thanks for looking into patches! A little bit later I will provide answer in other branch of discussion. > 15 янв. 2018 г., в 23:34, Alexander Korotkov > написал(а): > > I do not know, should I register separate commitfest entry? The code is very > close to main GiST VACUU

Re: New gist vacuum.

2018-01-15 Thread Alexander Korotkov
Hi! On Thu, Dec 28, 2017 at 2:37 PM, Andrey Borodin wrote: > > 19 дек. 2017 г., в 15:58, Andrey Borodin > написал(а): > > Here is the patch that deletes pages during GiST VACUUM. > > Here is new version of the patch for GiST VACUUM. > There are two main changes: > 1. During rescan for page dele

Re: New gist vacuum.

2018-01-15 Thread Alexander Korotkov
Hi! On Sat, Dec 30, 2017 at 12:18 PM, Andrey Borodin wrote: > > 28 дек. 2017 г., в 16:37, Andrey Borodin > написал(а): > > Here is new version of the patch for GiST VACUUM. > > There are two main changes: > > 1. During rescan for page deletion only know to be recently empty pages > are rescanne

Re: New gist vacuum.

2017-12-30 Thread Andrey Borodin
Hi! > 28 дек. 2017 г., в 16:37, Andrey Borodin написал(а): > Here is new version of the patch for GiST VACUUM. > There are two main changes: > 1. During rescan for page deletion only know to be recently empty pages are > rescanned. > 2. I've re-implemented physical scan with array instead of has

Re: New gist vacuum.

2017-12-28 Thread Andrey Borodin
Hi hackers! > 19 дек. 2017 г., в 15:58, Andrey Borodin написал(а): > Here is the patch that deletes pages during GiST VACUUM. Here is new version of the patch for GiST VACUUM. There are two main changes: 1. During rescan for page deletion only know to be recently empty pages are rescanned. 2. I'

Re: New gist vacuum.

2017-12-19 Thread Andrey Borodin
Hi hackers! Here is the patch that deletes pages during GiST VACUUM. > 12 нояб. 2017 г., в 23:20, Andrey Borodin написал(а): > > If author and community do not object, I want to continue work on > Konstantin's patch. ==Purpose== Long story short, some time ago Konstantin Kuznetsov hacked out