Re: Nitpick/question: Use of aliases for global variables in functions

2021-08-19 Thread Tom Lane
Corey Huinker writes: > In src/backend/access/transam/xact.c, I'm noticing a code style > inconsistency. > [ to wit, local variable alias for CurrentTransactionState or not ] > Is this something worth standardizing, and if so, which style do we like > better? I can't get excited about changing

Nitpick/question: Use of aliases for global variables in functions

2021-08-19 Thread Corey Huinker
I'm using an ongoing patch review to educate myself on parts of the codebase. In src/backend/access/transam/xact.c, I'm noticing a code style inconsistency. In some cases, a function will declare a variable of some struct pointer type, assign it to a globally declared struct, and then use it