Re: Non-emergency patch for bug #17679

2022-11-08 Thread Tom Lane
Andres Freund writes: > On 2022-11-08 11:28:08 -0500, Tom Lane wrote: >> Hence, the attached reverts everything 4ab5dae94 did to this function, >> and most of 0e758ae89 too, and instead makes IsBinaryUpgrade an >> additional reason to take the immediate-unlink path. > I wonder if it's worth aimin

Re: Non-emergency patch for bug #17679

2022-11-08 Thread Andres Freund
Hi, On 2022-11-08 11:28:08 -0500, Tom Lane wrote: > In the release team's discussion leading up to commit 0e758ae89, > Andres opined that what commit 4ab5dae94 had done to mdunlinkfork > was a mess, and I concur. It invented an entirely new code path > through that function, and required two diff

Non-emergency patch for bug #17679

2022-11-08 Thread Tom Lane
In the release team's discussion leading up to commit 0e758ae89, Andres opined that what commit 4ab5dae94 had done to mdunlinkfork was a mess, and I concur. It invented an entirely new code path through that function, and required two different behaviors from the segment-deletion loop. I think a