Re: Obsolete comment in partbounds.c

2019-11-04 Thread Alvaro Herrera
On 2019-Oct-19, Etsuro Fujita wrote: > On Fri, Oct 18, 2019 at 6:56 PM Alvaro Herrera > wrote: > > Yeah, agreed. Instead of "the null comes from" I would use "the > > partition that stores nulls". > > I think your wording is better than mine. Thank you for reviewing! Thanks for getting

Re: Obsolete comment in partbounds.c

2019-10-22 Thread Amit Langote
On Mon, Oct 21, 2019 at 5:44 PM Etsuro Fujita wrote: > On Sat, Oct 19, 2019 at 5:56 PM Etsuro Fujita wrote: > > On Fri, Oct 18, 2019 at 6:56 PM Alvaro Herrera > > wrote: > > > On 2019-Oct-18, Etsuro Fujita wrote: > > > > While reviewing the partitionwise-join patch, I noticed $Subject,ie, > >

Re: Obsolete comment in partbounds.c

2019-10-21 Thread Etsuro Fujita
On Sat, Oct 19, 2019 at 5:56 PM Etsuro Fujita wrote: > On Fri, Oct 18, 2019 at 6:56 PM Alvaro Herrera > wrote: > > On 2019-Oct-18, Etsuro Fujita wrote: > > > While reviewing the partitionwise-join patch, I noticed $Subject,ie, > > > this in create_list_bounds(): > > > > > > /* >

Re: Obsolete comment in partbounds.c

2019-10-19 Thread Etsuro Fujita
Hi Alvaro, On Fri, Oct 18, 2019 at 6:56 PM Alvaro Herrera wrote: > On 2019-Oct-18, Etsuro Fujita wrote: > > While reviewing the partitionwise-join patch, I noticed $Subject,ie, > > this in create_list_bounds(): > > > > /* > > * Never put a null into the values

Re: Obsolete comment in partbounds.c

2019-10-18 Thread Alvaro Herrera
On 2019-Oct-18, Etsuro Fujita wrote: > While reviewing the partitionwise-join patch, I noticed $Subject,ie, > this in create_list_bounds(): > > /* > * Never put a null into the values array, flag instead for > * the code further down below where

Obsolete comment in partbounds.c

2019-10-18 Thread Etsuro Fujita
While reviewing the partitionwise-join patch, I noticed $Subject,ie, this in create_list_bounds(): /* * Never put a null into the values array, flag instead for * the code further down below where we construct the actual *