On 04/07/2023 21:36, Tom Lane wrote:
Heikki Linnakangas writes:
Pushed a patch to remove the end-guard from the example in the pgindent
README. And fixed the bogus end-guard in walsender.c.
I don't see any actual push?
Forgot it after all. Pushed now, thanks.
--
Heikki Linnakangas
Neon (ht
ent
> README. And fixed the bogus end-guard in walsender.c.
I don't see any actual push?
> I'm not sure there is a universal best length. It depends on the comment
> what looks best. The very long ones in particular would not look good on
> comments in a deeply indented blo
long ones in particular would not look good on
comments in a deeply indented block. So I think the status quo is fine.
Looking at line 1 comments for fun shows pretty strong consistency:
1611 /*-
> On 30 Jun 2023, at 17:22, Tom Lane wrote:
> Seems reasonable; the trailing dashes eat a line without adding much.
+1
> Should we also provide specific guidance about how many leading dashes
> to use for this? I vaguely recall that pgindent might only need one,
> but I think using somewhere a
Heikki Linnakangas writes:
> Except for the translator comments, I think those others forgot about
> the end-guards by accident. But they look just as nice to me. It's
> probably not worth the code churn to remove them from existing comments,
> but how about we stop requiring them in new code,
I spotted this comment in walsender.c:
/*---
* When reading from a historic timeline, and there is a timeline switch
* [.. long comment omitted ...]
* portion of the old segment is copied to the new file. ---
*/
Note the bogus dashes at the
