Re: Open a streamed block for transactional messages during decoding

2023-10-30 Thread Amit Kapila
On Mon, Oct 30, 2023 at 2:17 PM Zhijie Hou (Fujitsu) wrote: > > On Monday, October 30, 2023 12:20 PM Amit Kapila > wrote: > > > > On Thu, Oct 26, 2023 at 2:01 PM Zhijie Hou (Fujitsu) > > > > wrote: > > > > > > On Thursday, October 26, 2023 12:42 PM Amit Kapila > > wrote: > > > > > > > > On Tu

RE: Open a streamed block for transactional messages during decoding

2023-10-30 Thread Zhijie Hou (Fujitsu)
On Monday, October 30, 2023 12:20 PM Amit Kapila wrote: > > On Thu, Oct 26, 2023 at 2:01 PM Zhijie Hou (Fujitsu) > wrote: > > > > On Thursday, October 26, 2023 12:42 PM Amit Kapila > wrote: > > > > > > On Tue, Oct 24, 2023 at 5:27 PM Zhijie Hou (Fujitsu) > > > > > > wrote: > > > > > > > > Whi

Re: Open a streamed block for transactional messages during decoding

2023-10-29 Thread Amit Kapila
On Thu, Oct 26, 2023 at 2:01 PM Zhijie Hou (Fujitsu) wrote: > > On Thursday, October 26, 2023 12:42 PM Amit Kapila > wrote: > > > > On Tue, Oct 24, 2023 at 5:27 PM Zhijie Hou (Fujitsu) > > > > wrote: > > > > > > While reviewing the test_decoding code, I noticed that when > > > skip_empty_xacts

RE: Open a streamed block for transactional messages during decoding

2023-10-26 Thread Zhijie Hou (Fujitsu)
On Thursday, October 26, 2023 12:42 PM Amit Kapila wrote: > > On Tue, Oct 24, 2023 at 5:27 PM Zhijie Hou (Fujitsu) > wrote: > > > > While reviewing the test_decoding code, I noticed that when > > skip_empty_xacts option is specified, it doesn't open the streaming > block( e.g. > > pg_output_str

Re: Open a streamed block for transactional messages during decoding

2023-10-25 Thread Amit Kapila
On Tue, Oct 24, 2023 at 5:27 PM Zhijie Hou (Fujitsu) wrote: > > While reviewing the test_decoding code, I noticed that when skip_empty_xacts > option is specified, it doesn't open the streaming block( e.g. > pg_output_stream_start) before streaming the transactional MESSAGE even if > it's > the f

Open a streamed block for transactional messages during decoding

2023-10-24 Thread Zhijie Hou (Fujitsu)
Hi, While reviewing the test_decoding code, I noticed that when skip_empty_xacts option is specified, it doesn't open the streaming block( e.g. pg_output_stream_start) before streaming the transactional MESSAGE even if it's the first change in a streaming block. It looks inconsistent with what we