Re: Opossum vs. float4 NaN

2019-01-27 Thread Tom Lane
Glyn Astill writes: > I guess the main question is; does anybody care about builds on a 20 year old > netbsd/mipsel dinosaur?  I noticed there are now mips64el and mips64eb > build-farm members. I tend to think that variety in the buildfarm is intrinsically a good thing. I'd rather see you

Re: Opossum vs. float4 NaN

2019-01-27 Thread Glyn Astill
>> On Saturday, 26 January 2019, 16:00:24 GMT, Tom Lane wrote: >> >> I'm thinking we should regretfully retire opossum, unless there's >> a software update available for it that fixes this bug. I'm happy to update opossum to see if the issue goes away; likewise I'm just as happy to retire it

Re: Opossum vs. float4 NaN

2019-01-26 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> The reason that it's reappeared is the refactoring we've done Tom> recently around snprintf: float4out is now taking its float4 Tom> argument and widening it to double to pass to strtod, which is Tom> where the checks for Inf/NaN happen. [...] Tom> to

Opossum vs. float4 NaN

2019-01-26 Thread Tom Lane
I see that opossum's owner just resurrected it after a period of being MIA ... and it's failing a few regression tests with symptoms like this: SELECT 'NaN'::float4; - float4 - -NaN + float4 +-- + Infinity (1 row) I have no doubt that this is caused by the same platform