Re: PGDOCS - Replica Identity quotes

2023-05-08 Thread Peter Smith
On Mon, May 8, 2023 at 2:05 PM Michael Paquier wrote: > > On Mon, May 08, 2023 at 01:57:33PM +1000, Peter Smith wrote: > > I agree. Do you want me to make a new v4 patch to also do that, or > > will you handle them in passing? > > I'll just go handle them on the way, no need to send an updated >

Re: PGDOCS - Replica Identity quotes

2023-05-07 Thread Michael Paquier
On Mon, May 08, 2023 at 01:57:33PM +1000, Peter Smith wrote: > I agree. Do you want me to make a new v4 patch to also do that, or > will you handle them in passing? I'll just go handle them on the way, no need to send an updated patch. -- Michael signature.asc Description: PGP signature

Re: PGDOCS - Replica Identity quotes

2023-05-07 Thread Peter Smith
On Mon, May 8, 2023 at 1:09 PM Michael Paquier wrote: > > On Mon, May 08, 2023 at 10:29:50AM +1000, Peter Smith wrote: > > Thanks for giving some feedback on my patch. > > Looks OK. > > While on it, looking at logical-replication.sgml, it seems to me that > these two are also incorrect, and we

Re: PGDOCS - Replica Identity quotes

2023-05-07 Thread Michael Paquier
On Mon, May 08, 2023 at 10:29:50AM +1000, Peter Smith wrote: > Thanks for giving some feedback on my patch. Looks OK. While on it, looking at logical-replication.sgml, it seems to me that these two are also incorrect, and we should use markups: implemented by walsender and apply -- Michael

Re: PGDOCS - Replica Identity quotes

2023-05-07 Thread Peter Smith
On Sat, May 6, 2023 at 5:28 AM David Zhang wrote: > > On 2023-03-16 4:46 p.m., Peter Smith wrote: > > A rebase was needed due to the recent REPLICA IDENTITY push [1]. > > > > PSA v2. > > > > > > - A published table must have a replica identity > > configured in > > + A published table

Re: PGDOCS - Replica Identity quotes

2023-05-05 Thread David Zhang
On 2023-03-16 4:46 p.m., Peter Smith wrote: A rebase was needed due to the recent REPLICA IDENTITY push [1]. PSA v2. - A published table must have a replica identity configured in + A published table must have a replica identity configured in +1 order to be able to replicate

Re: PGDOCS - Replica Identity quotes

2023-03-16 Thread Peter Smith
A rebase was needed due to the recent REPLICA IDENTITY push [1]. PSA v2. -- [1] https://github.com/postgres/postgres/commit/89e46da5e511a6970e26a020f265c9fb4b72b1d2 Kind Regards, Peter Smith. Fujitsu Australia v2-0001-PGDOCS-replica-identity-quotes.patch Description: Binary data

PGDOCS - Replica Identity quotes

2023-03-07 Thread Peter Smith
PGDOCS - Replica Identity quotes Hi, Here are some trivial quote changes to a paragraph describing REPLICA IDENTITY. These changes were previously made in another ongoing R.I. patch v28-0001 [1], but it was decided that since they are not strictly related to that patch they should done