On Wed, Mar 29, 2023 at 6:31 AM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit-san,
>
> > There is no need to break the link line. See attached.
>
> I understood your saying. I think it's better.
>
Pushed.
--
With Regards,
Amit Kapila.
Dear Amit-san,
> There is no need to break the link line. See attached.
I understood your saying. I think it's better.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
On Tue, Mar 28, 2023 at 1:00 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Amit,
>
> Thank you for reviewing! PSA new version.
>
> > Isn't it better to move the link-related part to the next line
> > wherever possible? Currently, it looks bit odd.
>
> Previously I preferred not to add a new line
Dear Amit,
Thank you for reviewing! PSA new version.
> Isn't it better to move the link-related part to the next line
> wherever possible? Currently, it looks bit odd.
Previously I preferred not to add a new line inside the tag, but it
caused
long-line. So I adjusted them not to be too
On Tue, Mar 28, 2023 at 9:49 AM Hayato Kuroda (Fujitsu)
wrote:
>
> Thank you for prompt reply!
>
> > Hmm, my above-suggested wording was “publish_via_partition_root
> > parameter “ but it seems you (accidentally?) omitted the word
> > “parameter”.
>
> It is my carelessness, sorry for
Thanks for this patch.
v5-0001 looks good to me.
v5-0002 looks good to me.
I've marked the CF entry [1] as "ready for committer".
--
[1] https://commitfest.postgresql.org/43/4256/
Kind Regards,
Peter Smith.
Fujitsu Australia
Dear Peter,
Thank you for prompt reply!
> Hmm, my above-suggested wording was “publish_via_partition_root
> parameter “ but it seems you (accidentally?) omitted the word
> “parameter”.
It is my carelessness, sorry for inconvenience. PSA new ones.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
On Tue, Mar 28, 2023 at 2:04 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Peter,
>
> Thank you for reviewing. PSA new version.
>
v4-0001 LGTM
>
> >
> > v3-0002
> >
> >
>
> > 2.2 doc/src/sgml/logical-replication.sgml (31.6. Restrictions)
> >
> > Publications can also specify that
Dear Peter,
Thank you for reviewing. PSA new version.
>
> v3-0001
>
>
> This patch looks good, but I think there are a couple of other places
> where you could add links:
>
> ~~~
>
> 1.1 doc/src/sgml/logical-replication.sgml (31.5 Conflicts)
>
> "When the streaming mode is
Hi Kuroda-san. Here are my review comments for both patches v3-0001 and v3-0002.
v3-0001
This patch looks good, but I think there are a couple of other places
where you could add links:
~~~
1.1 doc/src/sgml/logical-replication.sgml (31.5 Conflicts)
"When the streaming mode
Dear Peter,
Thank you for reviewing! PSA new version.
> doc/src/sgml/logical-replication.sgml
>
> 1.
> I am not sure your convention to only give the link to the FIRST
> reference on a page is good in all case. Maybe that rule is OK for
> multiple references all in the same sub-section but when
Dear Peter,
Thank you for reviewing! New patch set will be attached in later mail.
> ==
> Commit Message
>
> 1.
> In commit ecb696, an XML ID attribute was added to only one varlistentry,
> creating inconsistency with the commit 78ee60. This commit adds XML ID
> attributes to all
Here are review comments for v2-0002
==
doc/src/sgml/logical-replication.sgml
1.
I am not sure your convention to only give the link to the FIRST
reference on a page is good in all case. Maybe that rule is OK for
multiple references all in the same sub-section but when they are in
different
Here are review comments for v2-0001
==
Commit Message
1.
In commit ecb696, an XML ID attribute was added to only one varlistentry,
creating inconsistency with the commit 78ee60. This commit adds XML ID
attributes to all varlistentries in create_subscritpion.sgml for consistency.
Dear Peter,
Thank you for reviewing! PSA new patch set.
> 1.
> It will be better if all the references follow a consistent pattern:
>
> Rule 1 - IMO it is quite important/necessary for these option name
> “XXX” (see below) to be rendered using markup rather than
> just plain text font.
Firstly, +1 for this patch. Directly jumping to the subscription
options makes it much easier to navigate in the documentation instead
of scrolling up and done in CREATE SUBSCRIPTION page looking for each
parameter. Already (just experimenting with this patch) it is
noticeably better.
~~
Anyway,
Dear hackers, (CC: reviewers of copy-binary patch)
This is an follow-up thread of [1]. PSA patch that adds an attributes.
By ecb6965, an XML ID attribute is added only one varlistentry in
create_subscription.sgml.
But according to the commit 78ee60 and related discussions [2], [3], it is worth
17 matches
Mail list logo
