Re: PITR: enhance getRecordTimestamp()

2022-01-31 Thread Simon Riggs
On Thu, 27 Jan 2022 at 06:58, Michael Paquier wrote: > > On Wed, Nov 03, 2021 at 04:59:04PM +, Simon Riggs wrote: > > Thanks. Fixed and rebased. > > + if (xact_info == XLOG_XACT_PREPARE) > + { > + if (recoveryTargetUseOriginTime) > + { > +

Re: PITR: enhance getRecordTimestamp()

2022-01-26 Thread Michael Paquier
On Wed, Nov 03, 2021 at 04:59:04PM +, Simon Riggs wrote: > Thanks. Fixed and rebased. + if (xact_info == XLOG_XACT_PREPARE) + { + if (recoveryTargetUseOriginTime) + { + xl_xact_prepare *xlrec = (xl_xact_prepare *) XLogRecGetData(record); +

Re: PITR: enhance getRecordTimestamp()

2021-11-03 Thread Simon Riggs
On Wed, 3 Nov 2021 at 13:28, Daniel Gustafsson wrote: > > > On 30 Jun 2021, at 11:59, Simon Riggs wrote: > > > For PITR, getRecordTimestamp() did not include all record types that > > contain times. > > Add handling for checkpoints, end of recovery and prepared xact record > > types. > > +

Re: PITR: enhance getRecordTimestamp()

2021-11-03 Thread Daniel Gustafsson
> On 30 Jun 2021, at 11:59, Simon Riggs wrote: > For PITR, getRecordTimestamp() did not include all record types that > contain times. > Add handling for checkpoints, end of recovery and prepared xact record types. + This breaks doc compilation, and looks like a stray tag as you want this

PITR: enhance getRecordTimestamp()

2021-06-30 Thread Simon Riggs
For PITR, getRecordTimestamp() did not include all record types that contain times. Add handling for checkpoints, end of recovery and prepared xact record types. Based on earlier discussions with community members. Also, allow the option of recovery_target_use_origin_time = off (default) | on.