Re: Patch: Range Merge Join

2022-01-16 Thread Julien Rouhaud
Hi, On Wed, Nov 17, 2021 at 11:28:43PM +0100, Tomas Vondra wrote: > On 11/17/21 15:45, Thomas wrote: > > Thank you for the feedback and sorry for the oversight. I fixed the bug > > and attached a new version of the patch. > > > > Kind Regards, Thomas > > > > Am Mi., 17. Nov. 2021 um 15:03 Uhr

Re: Patch: Range Merge Join

2021-11-17 Thread Tomas Vondra
On 11/17/21 15:45, Thomas wrote: Thank you for the feedback and sorry for the oversight. I fixed the bug and attached a new version of the patch. Kind Regards, Thomas Am Mi., 17. Nov. 2021 um 15:03 Uhr schrieb Daniel Gustafsson mailto:dan...@yesql.se>>: This patch fails to compile due

Re: Patch: Range Merge Join

2021-11-17 Thread Thomas
Thank you for the feedback and sorry for the oversight. I fixed the bug and attached a new version of the patch. Kind Regards, Thomas Am Mi., 17. Nov. 2021 um 15:03 Uhr schrieb Daniel Gustafsson < dan...@yesql.se>: > This patch fails to compile due to an incorrect function name in an >

Re: Patch: Range Merge Join

2021-11-17 Thread Daniel Gustafsson
This patch fails to compile due to an incorrect function name in an assertion: nodeMergejoin.c:297:9: warning: implicit declaration of function 'list_legth' is invalid in C99 [-Wimplicit-function-declaration] Assert(list_legth(node->rangeclause) < 3); ^ -- Daniel Gustafsson

Re: Patch: Range Merge Join

2021-11-10 Thread Thomas
Dear all, thanks for the feedback! We had a closer look at the previous patches and the CustomScan infrastructure. Compared to the previous patch, we do not (directly) focus on joins with the overlap (&&) condition in this patch. Instead we consider joins with containment (@>) between a range

Re: Patch: Range Merge Join

2021-10-04 Thread Jaime Casanova
> On Mon, Oct 04, 2021 at 04:27:54PM -0500, Jaime Casanova wrote: >> On Thu, Jun 10, 2021 at 07:14:32PM -0700, Jeff Davis wrote: >> > >> > I'll start with the reason I set the work down before: it did not work >> > well with multiple join keys. That might be fine, but I also started >> > thinking

Re: Patch: Range Merge Join

2021-10-04 Thread Jaime Casanova
On Thu, Jun 10, 2021 at 07:14:32PM -0700, Jeff Davis wrote: > On Thu, 2021-06-10 at 15:09 +1200, David Rowley wrote: > > It shouldn't be a blocker for you, but just so you're aware, there > > was > > a previous proposal for this in [1] and a patch in [2]. I've include > > Jeff here just so he's

Re: Patch: Range Merge Join

2021-06-10 Thread Jeff Davis
On Thu, 2021-06-10 at 15:09 +1200, David Rowley wrote: > It shouldn't be a blocker for you, but just so you're aware, there > was > a previous proposal for this in [1] and a patch in [2]. I've include > Jeff here just so he's aware of this. Jeff may wish to state his > intentions with his own

Re: Patch: Range Merge Join

2021-06-10 Thread Thomas
Thank you for the feedback. I removed the redundant comments from the patch and added this thread to the July CF [1]. Best Regards, Thomas Mannhart [1] https://commitfest.postgresql.org/33/3160/ Am Do., 10. Juni 2021 um 05:10 Uhr schrieb David Rowley < dgrowle...@gmail.com>: > On Thu, 10 Jun

Re: Patch: Range Merge Join

2021-06-09 Thread David Rowley
On Thu, 10 Jun 2021 at 03:05, Thomas wrote: > We have implemented the Range Merge Join algorithm by extending the > existing Merge Join to also support range conditions, i.e., BETWEEN-AND > or @> (containment for range types). It shouldn't be a blocker for you, but just so you're aware, there