Re: Possible api miuse bms_next_member

2025-04-09 Thread David Rowley
On Thu, 10 Apr 2025 at 02:18, Tom Lane wrote: > If we did want to do something about this warning, rather than > hacking up the call sites I'd be inclined to invent something like > "bms_first_member()" which does the same thing but additionally > asserts on empty input. Not really convinced it's

Re: Possible api miuse bms_next_member

2025-04-09 Thread Tom Lane
Matthias van de Meent writes: > On Wed, 9 Apr 2025 at 15:01, Ranier Vilela wrote: >> Coverity has two new reports about use of the function *bms_next_member*. >> I think that he is right. > I don't know much about the planner, but I would expect a RelOptInfo's > relids field to always contain at

Re: Possible api miuse bms_next_member

2025-04-09 Thread Matthias van de Meent
On Wed, 9 Apr 2025 at 15:01, Ranier Vilela wrote: > > Hi. > > Per Coverity. > > CID 1608872: (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) > 32. negative_returns: bms_next_member(child_joinrel->relids, -1) is passed to > a parameter that cannot be negative.[show details] > > CID 16

Re: Possible api miuse bms_next_member

2025-04-09 Thread Ranier Vilela
Em qua., 9 de abr. de 2025 às 10:27, Matthias van de Meent < boekewurm+postg...@gmail.com> escreveu: > On Wed, 9 Apr 2025 at 15:01, Ranier Vilela wrote: > > > > Hi. > > > > Per Coverity. > > > > CID 1608872: (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) > > 32. negative_returns: bm

Possible api miuse bms_next_member

2025-04-09 Thread Ranier Vilela
Hi. Per Coverity. CID 1608872: (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS) 32. negative_returns: bms_next_member(child_joinrel->relids, -1) is passed to a parameter that cannot be negative.[show details] CID 1608871: (#1 of 1): Out-of-bounds access (OVERRUN) 32. overrun-buffer-a