Re: Possible copy and past error? (\usr\backend\commands\analyze.c)

2020-03-30 Thread Ranier Vilela
Em seg., 30 de mar. de 2020 às 06:06, Magnus Hagander escreveu: > On Sat, Mar 28, 2020 at 11:49 AM Ranier Vilela > wrote: > > > > Em sex., 27 de mar. de 2020 às 20:49, Tom Lane > escreveu: > >> > >> Ranier Vilela writes: > >> > Can someone check if there is a copy and paste error, at file: >

Re: Possible copy and past error? (\usr\backend\commands\analyze.c)

2020-03-30 Thread Ranier Vilela
Em seg., 30 de mar. de 2020 às 05:16, Michael Paquier escreveu: > On Sat, Mar 28, 2020 at 07:48:22AM -0300, Ranier Vilela wrote: > > I completely disagree. My tools have proven their worth, including > finding > > serious errors in the code, which fortunately have been fixed by other > >

Re: Possible copy and past error? (\usr\backend\commands\analyze.c)

2020-03-30 Thread Magnus Hagander
On Sat, Mar 28, 2020 at 11:49 AM Ranier Vilela wrote: > > Em sex., 27 de mar. de 2020 às 20:49, Tom Lane escreveu: >> >> Ranier Vilela writes: >> > Can someone check if there is a copy and paste error, at file: >> > \usr\backend\commands\analyze.c, at lines 2225 and 2226? >> > int num_mcv =

Re: Possible copy and past error? (\usr\backend\commands\analyze.c)

2020-03-30 Thread Michael Paquier
On Sat, Mar 28, 2020 at 07:48:22AM -0300, Ranier Vilela wrote: > I completely disagree. My tools have proven their worth, including finding > serious errors in the code, which fortunately have been fixed by other > committers. FWIW, I think that the rule to always take Coverity's reports with a

Re: Possible copy and past error? (\usr\backend\commands\analyze.c)

2020-03-28 Thread Ranier Vilela
Em sex., 27 de mar. de 2020 às 20:49, Tom Lane escreveu: > Ranier Vilela writes: > > Can someone check if there is a copy and paste error, at file: > > \usr\backend\commands\analyze.c, at lines 2225 and 2226? > > int num_mcv = stats->attr->attstattarget; > > int num_bins =

Re: Possible copy and past error? (\usr\backend\commands\analyze.c)

2020-03-27 Thread Tom Lane
Ranier Vilela writes: > Can someone check if there is a copy and paste error, at file: > \usr\backend\commands\analyze.c, at lines 2225 and 2226? > int num_mcv = stats->attr->attstattarget; > int num_bins = stats->attr->attstattarget; No, that's intentional I believe. Those are independent

Possible copy and past error? (\usr\backend\commands\analyze.c)

2020-03-27 Thread Ranier Vilela
Hi, Can someone check if there is a copy and paste error, at file: \usr\backend\commands\analyze.c, at lines 2225 and 2226? int num_mcv = stats->attr->attstattarget; int num_bins = stats->attr->attstattarget; If they really are the same values, it could be changed to: int num_mcv =