Re: Question about the Implementation of vector32_is_highbit_set on ARM

2023-11-23 Thread John Naylor
On Thu, Nov 23, 2023 at 4:29 PM Xiang Gao wrote: > > Thank you for your detailed explanation. > Can I do some testing and submit this patch? Please do, thanks.

RE: Question about the Implementation of vector32_is_highbit_set on ARM

2023-11-23 Thread Xiang Gao
On Date: Mon, 20 Nov 2023 16:05:43PM +0700, John Naylor wrote: >On Wed, Nov 8, 2023 at 2:44=E2=80=AFPM Xiang Gao wrote: >> * function. We could instead adopt the behavior of Arm's vmaxvq_u32(), i= >.e. >> * check each 32-bit element, but that would require an additional mask >> * operation on

Re: Question about the Implementation of vector32_is_highbit_set on ARM

2023-11-20 Thread John Naylor
On Wed, Nov 8, 2023 at 2:44 PM Xiang Gao wrote: > * function. We could instead adopt the behavior of Arm's vmaxvq_u32(), i.e. > * check each 32-bit element, but that would require an additional mask > * operation on x86. > */ > But I still don't understand why the vmaxvq_u32 intrinsic is

Question about the Implementation of vector32_is_highbit_set on ARM

2023-11-07 Thread Xiang Gao
Hi all, I have some questions about the implementation of vector32_is_highbit_set on arm. Below is the comment and the implementation for this function. /* * Exactly like vector8_is_highbit_set except for the input type, so it * looks at each byte separately. * * XXX x86 uses the same