Re: Question regarding heap_multi_insert documentation

2020-01-13 Thread Michael Paquier
On Mon, Jan 13, 2020 at 12:40:20AM +0100, Daniel Gustafsson wrote: > Thanks for clarifying. PFA tiny patch for this. Thanks, pushed. -- Michael signature.asc Description: PGP signature

Re: Question regarding heap_multi_insert documentation

2020-01-12 Thread Daniel Gustafsson
> On 13 Jan 2020, at 00:25, Tom Lane wrote: > > Daniel Gustafsson writes: >> The part I don't understand is "otherwise there race condition", it doesn't >> sound complete to me as a non-native english speaker. Should that really be >> "otherwise there *is a (potential)* race condition" or somet

Re: Question regarding heap_multi_insert documentation

2020-01-12 Thread Tom Lane
Daniel Gustafsson writes: > The part I don't understand is "otherwise there race condition", it doesn't > sound complete to me as a non-native english speaker. Should that really be > "otherwise there *is a (potential)* race condition" or something similar? I agree, it's missing "is a".

Question regarding heap_multi_insert documentation

2020-01-12 Thread Daniel Gustafsson
While reading the code for heapam.c:heap_multi_insert I happened upon this comment which I'm either too thick for, or it lacks a word or two: * .. * A check here does not definitively prevent a serialization anomaly; * that check MUST be done at least past the point of acquiring an