I wrote:
> Hmmm ... looking at PGTYPESnumeric_from_asc, it seems like the current
> behavior is different from what was described in that old thread; the only
> case where a digit buffer wouldn't be created is a NaN. But maybe a crash
> could occur for NaN. Perhaps we should use "if (num->sign
"Higuchi, Daisuke" writes:
> From: Tom Lane [mailto:t...@sss.pgh.pa.us]
>> So I think that we ought to unconditionally make the sqlda value's digit
>> buffer look just like the one we're copying, even when ndigits = 0,
>> which just requires removing the tests on ndigits.
> I agree with you.
From: Tom Lane [mailto:t...@sss.pgh.pa.us]
>I took a quick look at this.
Thank you for review.
>So I think that we ought to unconditionally make the sqlda value's digit
>buffer look just like the one we're copying, even when ndigits = 0,
>which just requires removing the tests on ndigits.
I
"Higuchi, Daisuke" writes:
> From: Dmitry Dolgov [mailto:9erthali...@gmail.com]
>> Thanks for the patches. Unfortunately, judging from the cfbot.cputube.org
>> they
>> can't be applied anymore to the current master, could you please rebase them?
> Thank you for checking!
> I rebased patches on
From: Dmitry Dolgov [mailto:9erthali...@gmail.com]
>Also what's strange for me is that after applying your patches I still got the
>same output, not sure why:
Hmm... In my environment, the output was changed.
I also updated regression test and cfbot.cputube.org reports no problem now.
Do you
> On Tue, 6 Nov 2018 at 10:19, Higuchi, Daisuke
> wrote:
>
> Thank you for checking!
> I rebased patches on the current master, so I attach them.
After adding 'EXEC SQL ALLOCATE DESCRIPTOR sqlda' I've managed to reproduce the
problem you're talking about, and indeed it looks strange:
=# table
From: Dmitry Dolgov [mailto:9erthali...@gmail.com]
> Thanks for the patches. Unfortunately, judging from the cfbot.cputube.org they
> can't be applied anymore to the current master, could you please rebase them?
Thank you for checking!
I rebased patches on the current master, so I attach them.
> On Thu, 17 May 2018 at 06:10, Higuchi, Daisuke
> wrote:
>
> Currently our customer uses PostgreSQL 9.6 and hits ECPG's bug during using
> numeric data type by SQLDA.
> I confirmed that this problem is occurred on master and 9.6 latest branch.
>
> FIX
> ---
