Re: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind

2023-04-03 Thread Tom Lane
Onur Tirtir writes: > Thank you for sharing your proposal as a patch. It looks much nicer and > useful than mine. > I've also tested it for a few cases --by injecting a memory error on > purpose-- and seen that it helps reporting the problematic query. > Should we move forward with v3 then? OK,

RE: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind

2023-04-03 Thread Onur Tirtir
rg Subject: Re: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind [You don't often get email from t...@sss.pgh.pa.us. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Onur Tirtir writes: > Thank you for reviewing t

Re: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind

2023-04-02 Thread Tom Lane
Onur Tirtir writes: > Thank you for reviewing the patch and for your feedback. I believe the v2 > patch should be able to handle other protocol messages too. I like the concept here, but the reporting that the v2 patch provides would be seriously horrid: it's trying to print stuff that isn't nec

RE: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind

2023-03-23 Thread Onur Tirtir
Hey Peter, Thank you for reviewing the patch and for your feedback. I believe the v2 patch should be able to handle other protocol messages too. -Original Message- From: Peter Eisentraut Sent: Wednesday, March 22, 2023 7:00 PM To: Onur Tirtir ; pgsql-hackers@lists.postgresql.org Subjec