Dear Michael,
I confirmed your commit. Thanks!
CF entry was closed as "Committed".
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
On Thu, Sep 28, 2023 at 02:23:59PM +1000, Peter Smith wrote:
> v4 LGTM.
Applied v4 down to 16, then.
--
Michael
signature.asc
Description: PGP signature
On Thu, 28 Sep 2023 12:54:33 +0900
Michael Paquier wrote:
> I was looking at this thread overall, the three v3 flavors of the doc
> changes and v4.
>
> -application_name value. Other characters
> will be
> -replaced with question marks (?).
> +application_name value.
> +
v4 LGTM.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Sep 28, 2023 at 03:23:30AM +, Hayato Kuroda (Fujitsu) wrote:
> Hmm, cfbot got angry because it tried to apply both of patches. To avoid it,
> I repost renamed patch.
> (I'm happy if we can specify the target branch of patches)
I was looking at this thread overall, the three v3
> I attached two patches - one is for HEAD, and another one is for REL_16_STABLE
> branch. As shown below, PG16 has the same behavior.
Hmm, cfbot got angry because it tried to apply both of patches. To avoid it, I
repost renamed patch.
(I'm happy if we can specify the target branch of patches)
Dear Tom,
Thank you for giving a comment!
New patch is available in [1].
> I'd be inclined to keep the text as simple as possible and not focus on
> the distinction between bytes and characters.
>
Okay, in the latest version, the word "byte" was removed.
[1]:
Dear Peter,
Thank you for reviewing!
> > > > > A. A patch which completely follows your comments. The name is
> > > > > "v3-0001-...patch". Cfbot tests it.
> > > > > B. A patch which completely follows Peter's comments [1]. The
> > > > > name is "Peter_v3-txt".
> > > > > C. A patch which
Dear Karl,
Thank you for giving comments! PSA new version.
I attached two patches - one is for HEAD, and another one is for REL_16_STABLE
branch. As shown below, PG16 has the same behavior.
```
psql (16beta3)
Type "help" for help.
postgres=# SET application_name TO 'あああ';
SET
postgres=# SHOW
On Thu, Sep 28, 2023 at 11:19 AM Tom Lane wrote:
>
> ... trailing bytes that could be mistaken for ASCII are precisely
> the property that causes us to reject an encoding as not backend-safe.
Oh, that is good to know. Thanks for the information.
==
Kind Regards,
Peter Smith.
Fujitsu
Peter Smith writes:
> I had in mind something like a SHIFT-JIS encoding where a single
> "character" may include some trail bytes that happen to be in the
> ASCII printable range. AFAIK because the new logic is processing
> bytes, not characters, I thought the end result could be a mix of
>
On Thu, Sep 28, 2023 at 10:30 AM Karl O. Pinc wrote:
>
> On Thu, 28 Sep 2023 09:49:03 +1000
> Peter Smith wrote:
>
> > On Wed, Sep 27, 2023 at 11:59 PM Karl O. Pinc
> > wrote:
> > >
> > > On Wed, 27 Sep 2023 12:58:54 +
> > > "Hayato Kuroda (Fujitsu)" wrote:
> > >
> > > > > Should the
On Thu, 28 Sep 2023 09:49:03 +1000
Peter Smith wrote:
> On Wed, Sep 27, 2023 at 11:59 PM Karl O. Pinc
> wrote:
> >
> > On Wed, 27 Sep 2023 12:58:54 +
> > "Hayato Kuroda (Fujitsu)" wrote:
> >
> > > > Should the committer be interested, your patch applies cleanly
> > > > and the docs build
On Wed, Sep 27, 2023 at 11:59 PM Karl O. Pinc wrote:
>
> On Wed, 27 Sep 2023 12:58:54 +
> "Hayato Kuroda (Fujitsu)" wrote:
>
> > > Should the committer be interested, your patch applies cleanly
> > > and the docs build as expected.
> >
> > Yeah, but cfbot accepted previous version. Did you
On Wed, 27 Sep 2023 12:58:54 +
"Hayato Kuroda (Fujitsu)" wrote:
> > Should the committer be interested, your patch applies cleanly
> > and the docs build as expected.
>
> Yeah, but cfbot accepted previous version. Did you have anything in
> your mind?
No. I'm letting the committer know
Dear Tom,
> No, I'm pretty sure you're mistaken. It's been a long time since
> high school English, but the way I think this works is that "that"
> introduces a restrictive clause, which narrows the scope of what
> you are saying. That is, you say "that" when you want to talk
> about only the
Dear Peter,
Thank you for reviewing!
>
> TBH, I felt the new text descriptions deviated a bit too much from the
> originals. IMO only quite a small tweak was needed, so my suggested
> text in the comments below reflects that.
Good point, my patch may be too much.
> Commit message.
>
> 1.
>
Dear Karl,
Thank you for reviewing!
> A related thing that's nice to have is to limit the line
> length of the documentation source to 80 characters or less.
> 79 is probably best. Since the source text around your patch
> conforms to this convention you should also.
IIUC it is not hard limit,
Hi Kuroda-san.
Here are my review comments for your v3 patch.
TBH, I felt the new text descriptions deviated a bit too much from the
originals. IMO only quite a small tweak was needed, so my suggested
text in the comments below reflects that.
==
Commit message.
1.
missing description
Sep 26, 2023 1:10:55 PM Tom Lane :
> "Karl O. Pinc" writes:
>> For the last hunk you'd change around "anything". Write:
>> "... it will be truncated to less than NAMEDATALEN characters and
>> the bytes of the string which are not printable ASCII characters ...".
>
>> Notice that I have also
"Karl O. Pinc" writes:
> For the last hunk you'd change around "anything". Write:
> "... it will be truncated to less than NAMEDATALEN characters and
> the bytes of the string which are not printable ASCII characters ...".
> Notice that I have also changed "that" to "which" just above.
> I
On Tue, 26 Sep 2023 13:40:26 +
"Hayato Kuroda (Fujitsu)" wrote:
> Your effort is quite helpful for me.
You're welcome.
> Before replying your comments, I thought I should show the difference
> between versions. Regarding old versions (here PG15 was used),
> non-ASCIIs (like Japanese) are
Dear Karl,
Thank you for reviewing! PSA new version.
> I see a few problems with the English and style of the patches
> and am commenting below and have signed up as a reviewer.
Your effort is quite helpful for me.
> At
> commitfest.postgresql.org I have marked the thread
> as needing author
Hello Hayato and Jian,
On Tue, 4 Jul 2023 01:30:56 +
"Hayato Kuroda (Fujitsu)" wrote:
> Dear Jian,
> > looks fine. Do you need to add to commitfest?
>
> Thank you for your confirmation. ! I registered to following:
>
> https://commitfest.postgresql.org/44/4437/
The way the Postgres
Dear Jian,
> On Thu, Jun 29, 2023 at 3:51 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Jian,
> >
> > Thank you for checking my patch!
> >
> > >
> > > in your patch:
> > > > printable ASCII characters will be replaced with a hex escape.
> > >
> > > My wording is not good. I think the result
On Thu, Jun 29, 2023 at 3:51 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Jian,
>
> Thank you for checking my patch!
>
> >
> > in your patch:
> > > printable ASCII characters will be replaced with a hex escape.
> >
> > My wording is not good. I think the result will be: ASCII characters
> > will be
Dear Jian,
Thank you for checking my patch!
>
> in your patch:
> > printable ASCII characters will be replaced with a hex escape.
>
> My wording is not good. I think the result will be: ASCII characters
> will be as is, non-ASCII characters will be replaced with "a hex
> escape".
Yeah,
On Fri, Jun 23, 2023 at 10:25 PM Hayato Kuroda (Fujitsu)
wrote:
>
> Dear hackers,
>
> While discussing based on the article[1] with Japanese developers,
> I found inconsistencies between codes and documents.
>
> 45b1a67a[2] changed the behavior when non-ASCII characters was set as
>
28 matches
Mail list logo
