Sorry, wrong patches again. Here are the correct ones.
Best regards,
Alyona Vinter
From baed4d6390737c4274cd4dc1c21d7bf488c673d4 Mon Sep 17 00:00:00 2001
From: Alena Vinter
Date: Tue, 2 Sep 2025 18:15:13 +0700
Subject: [PATCH 2/2] Implements helper function in recovery_gen
These functions suppor
Hi,
CFbot indicated some issues with the patch. I've attached rebased versions
of the patches, so hopefully everything will be ok this time.
Best regards,
Alyona Vinter
On Fri, 5 Sept 2025 at 12:51, Alyona Vinter wrote:
> Dear Hayato,
>
> Thank you for the review! My apologies for the error in
Dear Alyona,
Thanks for updating the patch!
Sadly, your patch cannot be applied cleanly. Even after the manual merge, it
could not
be built. Maybe `dbinfo` should be `dbinfos.dbinfo`. Obtained message is
written in [1].
(cfbot seemed not to run correctly)
Regarding patch content, your patch res
Dear Hayato,
Thank you for the review! My apologies for the error in the patch -- it
looks like I accidentally modified it before sending =(. I've attached the
fixed versions below.
> Regarding patch content, your patch restores the postgresql.auto.conf
after the
> command runs. Initially I felt
Dear Michael and Hayato,
Thank you both for your valuable feedback on the previous patch version.
I've reworked the patch based on your suggestions - the new version should
address the concerns about ALTER SYSTEM and follows the same patterns as
the 'setup_recovery' code.
I kept primary_conninfo
On Mon, Sep 01, 2025 at 02:06:34AM +, Hayato Kuroda (Fujitsu) wrote:
> WriteRecoveryConfig() has been used to setup the recovery parameters. Can we
> follow the way to restore them?
>
> Also, can we add a test to 040_pg_createsubscriber? IIUC it is enough to check
> one of recovery parameter i
Dear Laaren,
> I noticed that pg_createsubscriber sets recovery target params for
> correct recovery before converting a physical replica to a logical
> one but does not reset them afterward. It can lead to recovery
> failures in certain scenarios.
> For example, if recovery begins from a checkpoi
