Re: REL_15_STABLE: pgbench tests randomly failing on CI, Windows only

2023-10-10 Thread Noah Misch
On Sun, Oct 08, 2023 at 10:00:03PM -0700, David G. Johnston wrote: > On Sun, Oct 8, 2023 at 9:10 PM Noah Misch wrote: > > I didn't think of any phrasing that clearly explained things without the > > reader consulting the code. I considered these: I'm leaning toward: "socket file descriptor

Re: REL_15_STABLE: pgbench tests randomly failing on CI, Windows only

2023-10-08 Thread David G. Johnston
On Sun, Oct 8, 2023 at 9:10 PM Noah Misch wrote: > > I didn't think of any phrasing that clearly explained things without the > reader consulting the code. I considered these: > > "socket file descriptor out of range: %d" [what range?] > > Quick drive-by...but it seems that < 0 is a

Re: REL_15_STABLE: pgbench tests randomly failing on CI, Windows only

2023-10-08 Thread Noah Misch
On Mon, Oct 09, 2023 at 04:22:52PM +1300, Thomas Munro wrote: > On Mon, Oct 9, 2023 at 3:25 PM Noah Misch wrote: > > The "fd >= FD_SETSIZE" check is irrelevant on Windows. See comments in the > > attached patch; in brief, Windows assigns FDs and uses FD_SETSIZE > > differently. > > The first

Re: REL_15_STABLE: pgbench tests randomly failing on CI, Windows only

2023-10-08 Thread Thomas Munro
On Mon, Oct 9, 2023 at 3:25 PM Noah Misch wrote: > The "fd >= FD_SETSIZE" check is irrelevant on Windows. See comments in the > attached patch; in brief, Windows assigns FDs and uses FD_SETSIZE differently. > The first associated failure was commit dea12a1 (2023-08-03); as a doc commit, > it's

Re: REL_15_STABLE: pgbench tests randomly failing on CI, Windows only

2023-10-08 Thread Noah Misch
On Mon, Sep 04, 2023 at 03:18:40PM +1200, Thomas Munro wrote: > Somehow these tests have recently become unstable and have failed a few times: > > https://github.com/postgres/postgres/commits/REL_15_STABLE > > The failures are like: > > [22:32:26.722] # Failed test 'pgbench simple update stdout

REL_15_STABLE: pgbench tests randomly failing on CI, Windows only

2023-09-03 Thread Thomas Munro
Hi, Somehow these tests have recently become unstable and have failed a few times: https://github.com/postgres/postgres/commits/REL_15_STABLE The failures are like: [22:32:26.722] # Failed test 'pgbench simple update stdout /(?^:builtin: simple update)/' [22:32:26.722] # at