Re: [HACKERS] proposal: schema variables

po 18. 11. 2019 v 19:47 odesílatel Pavel Stehule napsal: > > > ne 3. 11. 2019 v 17:27 odesílatel Pavel Stehule > napsal: > >> >> >> čt 10. 10. 2019 v 11:41 odesílatel Pavel Stehule >> napsal: >> >>> Hi >>> >>> minor change - replace heap_tuple_fetch_attr by detoast_external_attr. >>> >>> >>

Re: [HACKERS] proposal: schema variables

ne 3. 11. 2019 v 17:27 odesílatel Pavel Stehule napsal: > > > čt 10. 10. 2019 v 11:41 odesílatel Pavel Stehule > napsal: > >> Hi >> >> minor change - replace heap_tuple_fetch_attr by detoast_external_attr. >> >> > similar update - heap_open, heap_close was replaced by table_open, > table_close

Re: [HACKERS] proposal: schema variables

čt 10. 10. 2019 v 11:41 odesílatel Pavel Stehule napsal: > Hi > > minor change - replace heap_tuple_fetch_attr by detoast_external_attr. > > similar update - heap_open, heap_close was replaced by table_open, table_close Regards Pavel schema_variables-20191103.patch.gz Description:

Re: [HACKERS] proposal: schema variables

Hi minor change - replace heap_tuple_fetch_attr by detoast_external_attr. Regards Pavel pá 4. 10. 2019 v 6:12 odesílatel Pavel Stehule napsal: > Hi > > so 10. 8. 2019 v 9:10 odesílatel Pavel Stehule > napsal: > >> Hi >> >> just rebase >> > > fresh rebase > > Regards > > Pavel > > >> Regards

Re: [HACKERS] proposal: schema variables

Hi so 10. 8. 2019 v 9:10 odesílatel Pavel Stehule napsal: > Hi > > just rebase > fresh rebase Regards Pavel > Regards > > Pavel > schema-variables-20191004.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

Hi just rebase Regards Pavel schema-variables-rebase-20190810.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

Hi ne 30. 6. 2019 v 5:10 odesílatel Pavel Stehule napsal: > > > pá 24. 5. 2019 v 19:12 odesílatel Pavel Stehule > napsal: > >> Hi >> >> čt 9. 5. 2019 v 6:34 odesílatel Pavel Stehule >> napsal: >> >>> Hi >>> >>> rebased patch >>> >> >> rebase after pgindent >> > > fresh rebase > just rebase

Re: [HACKERS] proposal: schema variables

pá 24. 5. 2019 v 19:12 odesílatel Pavel Stehule napsal: > Hi > > čt 9. 5. 2019 v 6:34 odesílatel Pavel Stehule > napsal: > >> Hi >> >> rebased patch >> > > rebase after pgindent > fresh rebase Regards Pavel > Regards > > Pavel > >> >> Regards >> >> Pavel >> >> >>

Re: [HACKERS] proposal: schema variables

Hi čt 9. 5. 2019 v 6:34 odesílatel Pavel Stehule napsal: > Hi > > rebased patch > rebase after pgindent Regards Pavel > > Regards > > Pavel > > > schema-variables-20190524.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

Hi rebased patch Regards Pavel schema-variables-20190509.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

fresh rebase Regards Pavel schema-variables-20180419.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

út 26. 3. 2019 v 6:40 odesílatel Pavel Stehule napsal: > Hi > > ne 24. 3. 2019 v 6:57 odesílatel Pavel Stehule > napsal: > >> Hi >> >> rebase against current master >> > > > fixed issue IF NOT EXISTS & related regress tests > another rebase Regards Pavel > Regards > > Pavel > > >> Regards

Re: [HACKERS] proposal: schema variables

po 25. 3. 2019 v 20:40 odesílatel Erik Rijkers napsal: > On 2019-03-24 10:32, Pavel Stehule wrote: > > ne 24. 3. 2019 v 10:25 odesílatel Erik Rijkers napsal: > > > >> On 2019-03-24 06:57, Pavel Stehule wrote: > >> > Hi > >> > > >> > rebase against current master > >> > >> I ran into this: > >>

Re: [HACKERS] proposal: schema variables

Hi ne 24. 3. 2019 v 6:57 odesílatel Pavel Stehule napsal: > Hi > > rebase against current master > fixed issue IF NOT EXISTS & related regress tests Regards Pavel > Regards > > Pavel > schema-variables-20190326.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

On 2019-03-24 10:32, Pavel Stehule wrote: ne 24. 3. 2019 v 10:25 odesílatel Erik Rijkers napsal: On 2019-03-24 06:57, Pavel Stehule wrote: > Hi > > rebase against current master I ran into this: (schema 'varschema2' does not exist): drop variable varschema2.testv cascade; ERROR: schema

Re: [HACKERS] proposal: schema variables

ne 24. 3. 2019 v 10:25 odesílatel Erik Rijkers napsal: > On 2019-03-24 06:57, Pavel Stehule wrote: > > Hi > > > > rebase against current master > > > > I ran into this: > > (schema 'varschema2' does not exist): > > drop variable varschema2.testv cascade; > ERROR: schema "varschema2" does not

Re: [HACKERS] proposal: schema variables

On 2019-03-24 06:57, Pavel Stehule wrote: Hi rebase against current master I ran into this: (schema 'varschema2' does not exist): drop variable varschema2.testv cascade; ERROR: schema "varschema2" does not exist create variable if not exists testv as text; server closed the connection

Re: [HACKERS] proposal: schema variables

Hi rebase against current master Regards Pavel schema-variables-20190324.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

On 3/7/19 10:10 AM, Fabien COELHO wrote: Anyway, the patch is non trivial and very large, so targetting v12 now is indeed out of reach. Agreed. I have set the target version to PG13. Regards, -- -David da...@pgmasters.net

Re: Re: [HACKERS] proposal: schema variables

Hi >> My strong opinion based on the underlying use case is that it that such >> session variables should be transactional by default, and Pavel strong >> opinion is that they should not, to be closer to Oracle comparable >> feature. > > It is closer to any known database Oracle, DB2, Firebird,

Re: Re: [HACKERS] proposal: schema variables

čt 7. 3. 2019 v 9:10 odesílatel Fabien COELHO napsal: > > Hello David, > > > This patch hasn't receive any review in a while and I'm not sure if > that's > > because nobody is interested or the reviewers think it does not need any > more > > review. > > > > It seems to me that this patch as

Re: Re: [HACKERS] proposal: schema variables

Hello David, This patch hasn't receive any review in a while and I'm not sure if that's because nobody is interested or the reviewers think it does not need any more review. It seems to me that this patch as implemented does not quite satisfy any one. I think we need to hear something

Re: Re: [HACKERS] proposal: schema variables

On 3/3/19 10:27 PM, Pavel Stehule wrote: rebase and fix compilation due changes related pg_dump This patch hasn't receive any review in a while and I'm not sure if that's because nobody is interested or the reviewers think it does not need any more review. It seems to me that this patch

Re: [HACKERS] proposal: schema variables

Hi just rebase regards Pavel schema-variables-20190131.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

Hi just rebase Regards Pavel schema-variables-20190130.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

Hi fresh rebased patch, no other changes Pavel schema-variables-20190122-01.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

On 2018-12-31 14:23, Pavel Stehule wrote: st 21. 11. 2018 v 8:24 odesílatel Pavel Stehule [schema-variables-20181231-01.patch.gz] Hi Pavel, I gave this a quick try-out with the script I had from previous versions, and found these two errors: drop schema if exists schema1

Re: [HACKERS] proposal: schema variables

st 21. 11. 2018 v 8:24 odesílatel Pavel Stehule napsal: > Hi > > just rebase > > rebase Regards Pavel > > Regards > > Pavel > schema-variables-20181231-01.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

so 1. 12. 2018 v 0:16 odesílatel Dmitry Dolgov <9erthali...@gmail.com> napsal: > > On Wed, Nov 21, 2018 at 8:25 AM Pavel Stehule > wrote: > > > > just rebase > > Thanks for working on this patch. > > I'm a bit confused, but cfbot again says that there are some conflicts. > Probably they are the

Re: [HACKERS] proposal: schema variables

> On Wed, Nov 21, 2018 at 8:25 AM Pavel Stehule wrote: > > just rebase Thanks for working on this patch. I'm a bit confused, but cfbot again says that there are some conflicts. Probably they are the minor one, from src/bin/psql/help.c For now I'm moving it to the next CF.

Re: [HACKERS] proposal: schema variables

Hi just rebase Regards Pavel schema-variables-20181121-01.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

Hi út 23. 10. 2018 v 14:50 odesílatel Erik Rijkers napsal: > > [schema-variables-20181007-01.patch.gz] > > Hi, > > I tried to test your schema-variables patch but got stuck here instead > (after applying succesfully on top of e6f5d1acc): > > make[2]: *** No rule to make target >

Re: [HACKERS] proposal: schema variables

[schema-variables-20181007-01.patch.gz] Hi, I tried to test your schema-variables patch but got stuck here instead (after applying succesfully on top of e6f5d1acc): make[2]: *** No rule to make target '../../../src/include/catalog/pg_variable.h', needed by 'bki-stamp'. Stop. make[1]:

Re: [HACKERS] proposal: schema variables

Hi ne 30. 9. 2018 v 0:19 odesílatel Pavel Stehule napsal: > > > so 29. 9. 2018 v 10:34 odesílatel Pavel Stehule > napsal: > >> >> >> so 22. 9. 2018 v 8:00 odesílatel Pavel Stehule >> napsal: >> >>> Hi >>> >>> rebased against yesterday changes in tab-complete.c >>> >> >> rebased against last

Re: [HACKERS] proposal: schema variables

st 3. 10. 2018 v 1:01 odesílatel Thomas Munro napsal: > On Sun, Sep 30, 2018 at 11:20 AM Pavel Stehule > wrote: > > I hope so now, there are almost complete functionality. Please, check it. > > Hi Pavel, > > FYI there is a regression test failure on Windows: > > plpgsql ... FAILED > > ***

Re: [HACKERS] proposal: schema variables

On Sun, Sep 30, 2018 at 11:20 AM Pavel Stehule wrote: > I hope so now, there are almost complete functionality. Please, check it. Hi Pavel, FYI there is a regression test failure on Windows: plpgsql ... FAILED *** 4071,4077 end; $$ language plpgsql; select stacked_diagnostics_test(); -

Re: [HACKERS] proposal: schema variables

so 29. 9. 2018 v 10:34 odesílatel Pavel Stehule napsal: > > > so 22. 9. 2018 v 8:00 odesílatel Pavel Stehule > napsal: > >> Hi >> >> rebased against yesterday changes in tab-complete.c >> > > rebased against last changes in master > + using content of schema variable for estimation +

Re: [HACKERS] proposal: schema variables

so 22. 9. 2018 v 8:00 odesílatel Pavel Stehule napsal: > Hi > > rebased against yesterday changes in tab-complete.c > rebased against last changes in master Regards Pavel > Regards > > Pavel > schema-variables-20180929-01.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

Hi rebased against yesterday changes in tab-complete.c Regards Pavel schema-variables-20180922-01.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

pá 21. 9. 2018 v 21:46 odesílatel Arthur Zakirov napsal: > On Wed, Sep 19, 2018 at 04:36:40PM +0200, Pavel Stehule wrote: > > ON COMMIT DROP is used only for temp variables (transaction or not > > transaction). The purpose is same like for tables. Sometimes you can to > > have object with

Re: [HACKERS] proposal: schema variables

On Wed, Sep 19, 2018 at 04:36:40PM +0200, Pavel Stehule wrote: > ON COMMIT DROP is used only for temp variables (transaction or not > transaction). The purpose is same like for tables. Sometimes you can to > have object with shorter life than is session. > > ON TRANSACTION END RESET has sense

Re: [HACKERS] proposal: schema variables

Hi st 19. 9. 2018 v 13:23 odesílatel Arthur Zakirov napsal: > Hello, > > On Wed, Sep 19, 2018 at 10:30:31AM +0200, Pavel Stehule wrote: > > Hi > > > > new update: > > > > I fixed pg_restore, and I cleaned a code related to transaction > processing > > > > There should be a full functionality

Re: [HACKERS] proposal: schema variables

st 19. 9. 2018 v 14:53 odesílatel Arthur Zakirov napsal: > On Wed, Sep 19, 2018 at 02:08:04PM +0200, Pavel Stehule wrote: > > Unfortunately we cannot to use standard > > "SET" command, because it is used in Postgres for different purpose. > > READ|WRITE are totally clear, and for user it is

Re: [HACKERS] proposal: schema variables

On Wed, Sep 19, 2018 at 02:08:04PM +0200, Pavel Stehule wrote: > Unfortunately we cannot to use standard > "SET" command, because it is used in Postgres for different purpose. > READ|WRITE are totally clear, and for user it is another signal so > variables are different than tables (so it is not

Re: [HACKERS] proposal: schema variables

Hi st 19. 9. 2018 v 13:23 odesílatel Arthur Zakirov napsal: > Hello, > > On Wed, Sep 19, 2018 at 10:30:31AM +0200, Pavel Stehule wrote: > > Hi > > > > new update: > > > > I fixed pg_restore, and I cleaned a code related to transaction > processing > > > > There should be a full functionality

Re: [HACKERS] proposal: schema variables

Hello, On Wed, Sep 19, 2018 at 10:30:31AM +0200, Pavel Stehule wrote: > Hi > > new update: > > I fixed pg_restore, and I cleaned a code related to transaction processing > > There should be a full functionality now. I reviewed a little bit the patch. I have a few comments. > pg_views Columns

Re: [HACKERS] proposal: schema variables

Hi new update: I fixed pg_restore, and I cleaned a code related to transaction processing There should be a full functionality now. Regards Pavel schema-variables-20180919-01.patch.gz Description: application/gzip

Re: [HACKERS] proposal: schema variables

so 15. 9. 2018 v 18:06 odesílatel Pavel Stehule napsal: > > > > >> The code is more cleaner now, there are more tests, and documentation is >> mostly complete. I am sorry - my English is not good. >> New features: >> >> o ON COMMIT DROP and ON TRANSACTION END RESET -- remove temp variable on >>

Re: [HACKERS] proposal: schema variables

> The code is more cleaner now, there are more tests, and documentation is > mostly complete. I am sorry - my English is not good. > New features: > > o ON COMMIT DROP and ON TRANSACTION END RESET -- remove temp variable on > commit, reset variable on transaction end (commit, rollback) > o LET var

Re: [HACKERS] proposal: schema variables

2018-09-07 14:34 GMT+02:00 Fabien COELHO : > > Hello Pavel, > > here is updated patch - I wrote some transactional support >> >> I am not sure how these new features are understandable and if these >> features does it better or not. >> > > There are possibility to reset to default value when >>

Re: [HACKERS] proposal: schema variables

Hello Pavel, here is updated patch - I wrote some transactional support I am not sure how these new features are understandable and if these features does it better or not. There are possibility to reset to default value when a) any transaction is finished - the scope of value is limited

Re: [HACKERS] proposal: schema variables

Hi 2018-09-04 9:21 GMT+02:00 Dean Rasheed : > AFAICS this patch does nothing to consider parallel safety -- that is, > as things stand, a variable is allowed in a query that may be > parallelised, but its value is not copied to workers, leading to > incorrect results. For example: > > create

Re: [HACKERS] proposal: schema variables

AFAICS this patch does nothing to consider parallel safety -- that is, as things stand, a variable is allowed in a query that may be parallelised, but its value is not copied to workers, leading to incorrect results. For example: create table foo(a int); insert into foo select * from

Re: [HACKERS] proposal: schema variables

Hello Pavel L. I do not understand your point, as usual. I raise a factual issue about security, and you do not answer how this can be solved with your proposal, but appeal to argument of authority and declare your "strong opinion". I do not see any intrinsic opposition between having

Re: [HACKERS] proposal: schema variables

On 23.08.2018 12:46, Fabien COELHO wrote: I do not understand your point, as usual. I raise a factual issue about security, and you do not answer how this can be solved with your proposal, but appeal to argument of authority and declare your "strong opinion". I do not see any intrinsic

Re: [HACKERS] proposal: schema variables

Security vs "good enough in some cases" looks bad to me. We don't find a agreement, because you are concentrated on transation, me on session. And we have different expectations. I do not understand your point, as usual. I raise a factual issue about security, and you do not answer how

Re: [HACKERS] proposal: schema variables

2018-08-23 10:17 GMT+02:00 Fabien COELHO : > > Hello Pavel, > > 2. holding some session based informations, that can be used in security >> definer functions. >> > > Hmmm, I see our disagreement. My point is that this feature is *NOT* fit > for security-related uses because if the transaction

Re: [HACKERS] proposal: schema variables

Hello Pavel, 2. holding some session based informations, that can be used in security definer functions. Hmmm, I see our disagreement. My point is that this feature is *NOT* fit for security-related uses because if the transaction fails the variable would keep the value it had if the

Re: [HACKERS] proposal: schema variables

2018-08-22 9:00 GMT+02:00 Fabien COELHO : > > Hello Pavel, > > AFAICR, I had an objection on such new objects when you first proposed >>> something similar in October 2016. >>> >>> Namely, if session variables are not transactional, they cannot be used >>> to >>> implement security related

Re: [HACKERS] proposal: schema variables

Hello Pavel, AFAICR, I had an objection on such new objects when you first proposed something similar in October 2016. Namely, if session variables are not transactional, they cannot be used to implement security related auditing features which were advertised as the motivating use case: an

Re: [HACKERS] proposal: schema variables

Hi Fabien Dne út 21. 8. 2018 19:56 uživatel Fabien COELHO napsal: > > Hello Pavel, > > AFAICR, I had an objection on such new objects when you first proposed > something similar in October 2016. > > Namely, if session variables are not transactional, they cannot be used to > implement security

Re: [HACKERS] proposal: schema variables

Hello Pavel, AFAICR, I had an objection on such new objects when you first proposed something similar in October 2016. Namely, if session variables are not transactional, they cannot be used to implement security related auditing features which were advertised as the motivating use case:

Re: [HACKERS] proposal: schema variables

2018-06-27 19:15 GMT+02:00 Gilles Darold : > Le 27/06/2018 à 13:22, Pavel Stehule a écrit : > > Hi > > 2018-06-27 12:21 GMT+02:00 Gilles Darold : > >> Hi, >> >> I'm reviewing the patch as it was flagged in the current commit fest. >> Here are my feedback: >> >> - The patch need to be rebased due

Re: [HACKERS] proposal: schema variables

Le 27/06/2018 à 13:22, Pavel Stehule a écrit : Hi 2018-06-27 12:21 GMT+02:00 Gilles Darold >: Hi, I'm reviewing the patch as it was flagged in the current commit fest. Here are my feedback:  - The patch need to be rebased due to changes in

Re: [HACKERS] proposal: schema variables

Hi 2018-06-27 12:21 GMT+02:00 Gilles Darold : > Hi, > > I'm reviewing the patch as it was flagged in the current commit fest. Here > are my feedback: > > - The patch need to be rebased due to changes in file > src/sgml/catalogs.sgml > > - Some compilation warning must be fixed: > > analyze.c:

Re: [HACKERS] proposal: schema variables

Hi, I'm reviewing the patch as it was flagged in the current commit fest. Here are my feedback:  - The patch need to be rebased due to changes in file src/sgml/catalogs.sgml  - Some compilation warning must be fixed: analyze.c: In function ‘transformLetStmt’: analyze.c:1568:17:

Re: [HACKERS] proposal: schema variables

Hi 2018-05-01 3:56 GMT+02:00 Peter Eisentraut : > On 4/20/18 13:45, Pavel Stehule wrote: > > I dunno, it seems awfully different to me. There's only one > "column", > > right? What code is really shared here? Are constraints and > triggers > >

Re: [HACKERS] proposal: schema variables

On 4/20/18 13:45, Pavel Stehule wrote: > I dunno, it seems awfully different to me.  There's only one "column", > right?  What code is really shared here?  Are constraints and triggers > even desirable feature for variables?  What would be the use case? > > > The schema variable can

Re: [HACKERS] proposal: schema variables

2018-04-20 17:32 GMT+02:00 Robert Haas : > On Tue, Apr 17, 2018 at 12:28 PM, Pavel Stehule > wrote: > > It true, so there are lot of "unused" attributes for this purpose, but > there > > is lot of shared attributes, and lot of shared code.

Re: [HACKERS] proposal: schema variables

On Tue, Apr 17, 2018 at 12:28 PM, Pavel Stehule wrote: > It true, so there are lot of "unused" attributes for this purpose, but there > is lot of shared attributes, and lot of shared code. Semantically, I see > variables in family of sequences, tables, indexes, views.

Re: [HACKERS] proposal: schema variables

On Tue, Apr 17, 2018 at 06:28:19PM +0200, Pavel Stehule wrote: > I though about it, and I am inclined to prefer pg_class instead separate > tables. > > It true, so there are lot of "unused" attributes for this purpose, but > there is lot of shared attributes, and lot of shared code. Semantically,

Re: [HACKERS] proposal: schema variables

Hi 2018-04-17 16:14 GMT+02:00 Arthur Zakirov : > Hello Pavel, > > On Thu, Oct 26, 2017 at 09:21:24AM +0200, Pavel Stehule wrote: > > I hope so this proposal is good enough and simple. > > > > Comments, notes? > > As I understood variables are stored in pg_class table.

Re: [HACKERS] proposal: schema variables

Hello Pavel, On Thu, Oct 26, 2017 at 09:21:24AM +0200, Pavel Stehule wrote: > I hope so this proposal is good enough and simple. > > Comments, notes? As I understood variables are stored in pg_class table. Did you consider storing variables in a special catalog table? It can be named as

Re: [HACKERS] proposal: schema variables

2018-03-21 6:24 GMT+01:00 Pavel Stehule : > > > 2018-03-20 18:38 GMT+01:00 Pavel Stehule : > >> Hi >> >> I am sending new update. The code is less ugly, and the current >> functionality is +/- final for first stage. It should be good enough for >>

Re: [HACKERS] proposal: schema variables

2018-03-12 16:38 GMT+01:00 Pavel Luzanov : > > On 12.03.2018 09:54, Pavel Stehule wrote: > > > 2018-03-12 7:49 GMT+01:00 Pavel Luzanov : > >> >> Is there any chances that it will work on replicas? >> > ... > > sure, it should to work. Now, I am

Re: [HACKERS] proposal: schema variables

On 12.03.2018 09:54, Pavel Stehule wrote: 2018-03-12 7:49 GMT+01:00 Pavel Luzanov >: Is there any chances that it will work on replicas? ... sure, it should to work. Now, I am try to solve a issues on concept level - the LET

Re: [HACKERS] proposal: schema variables

2018-03-12 7:49 GMT+01:00 Pavel Luzanov : > Hi, > > I plan to make usability and feature test review in several days. > > Is there any chances that it will work on replicas? > Such possibility is very helpful in generating reports. > Now, LET command produces an error: >

Re: [HACKERS] proposal: schema variables

Hi, I plan to make usability and feature test review in several days. Is there any chances that it will work on replicas? Such possibility is very helpful in generating reports. Now, LET command produces an error: ERROR:  cannot execute LET in a read-only transaction But if we say that

Re: [HACKERS] proposal: schema variables

Hi 2018-02-03 1:48 GMT+01:00 David G. Johnston : > ​I've done a non-compilation documentation review, the diff from the poc > patch and the diff from master are attached. > > Comments are inter-twined in the patch in xml comment format; though I > reiterate (some of?)