Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

On 4/10/18 9:17 AM, Alvaro Herrera wrote: > Nikolay Shaplov wrote: > >> But I need some confirmation, in order not to write patch in vain again :-) > > Don't worry, rest assured that you will still write *many* patches in > vain, not just this one. Despite the rather dubious pep talk, Álvaro is

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

В письме от 10 апреля 2018 08:55:52 пользователь David Steele написал: > On 1/25/18 12:27 PM, Nikolay Shaplov wrote: > > В письме от 25 января 2018 11:29:34 пользователь Tom Lane написал: > >> Alvaro Herrera writes: > >>> Tom Lane wrote: > Well, maybe the right

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

On 1/25/18 12:27 PM, Nikolay Shaplov wrote: > В письме от 25 января 2018 11:29:34 пользователь Tom Lane написал: >> Alvaro Herrera writes: >>> Tom Lane wrote: Well, maybe the right answer is to address that. It's clear to me why that would happen if we store

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

On 1/25/18 09:40, Tom Lane wrote: > Peter Eisentraut writes: >> On 1/23/18 13:39, Robert Haas wrote: >>> I don't understand. AAUI, it is currently the case that if you set >>> the options before the TOAST table exists, they are lost. > >> Well, that's also

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

В письме от 25 января 2018 11:29:34 пользователь Tom Lane написал: > Alvaro Herrera writes: > > Tom Lane wrote: > >> Well, maybe the right answer is to address that. It's clear to me > >> why that would happen if we store these things as reloptions on the > >> toast

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

Alvaro Herrera writes: > Tom Lane wrote: >> Well, maybe the right answer is to address that. It's clear to me >> why that would happen if we store these things as reloptions on the >> toast table, but can't they be stored on the parent table? > Actually, Nikolay

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

Tom Lane wrote: > Peter Eisentraut writes: > > On 1/23/18 13:39, Robert Haas wrote: > >> I don't understand. AAUI, it is currently the case that if you set > >> the options before the TOAST table exists, they are lost. > > > Well, that's also weird. > > Well,

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

Peter Eisentraut writes: > On 1/23/18 13:39, Robert Haas wrote: >> I don't understand. AAUI, it is currently the case that if you set >> the options before the TOAST table exists, they are lost. > Well, that's also weird. Well, maybe the right answer is to

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

On 1/23/18 13:39, Robert Haas wrote: > On Tue, Jan 23, 2018 at 12:03 PM, Peter Eisentraut > wrote: >> It might also be useful to set these reloptions before you add a new >> column to a table. > > I don't understand. AAUI, it is currently the case that if you

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

В письме от 23 января 2018 12:03:50 пользователь Peter Eisentraut написал: > >>> This patch raises error if user tries o set or change toast.* option for > >>> a table that does not have a TOST relation. > > > > There might be a case for raising a warning in this situation, > > but I would

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

On Tue, Jan 23, 2018 at 12:03 PM, Peter Eisentraut wrote: > It might also be useful to set these reloptions before you add a new > column to a table. I don't understand. AAUI, it is currently the case that if you set the options before the TOAST table exists,

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

On 1/18/18 18:42, Tom Lane wrote: > Robert Haas writes: >> On Wed, Jan 17, 2018 at 3:50 PM, Nikolay Shaplov wrote: >>> This patch raises error if user tries o set or change toast.* option for a >>> table that does not have a TOST relation. > There might

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

В письме от 18 января 2018 18:42:01 пользователь Tom Lane написал: > >> This patch raises error if user tries o set or change toast.* option for > >> a > >> table that does not have a TOST relation. > > > > I think there is a problem with this idea, which is that the rules for > > whether or not

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

Robert Haas writes: > On Wed, Jan 17, 2018 at 3:50 PM, Nikolay Shaplov wrote: >> This patch raises error if user tries o set or change toast.* option for a >> table that does not have a TOST relation. > I think there is a problem with this idea, which is

Re: [PATCH][PROPOSAL] Refuse setting toast.* reloptions when TOAST table does not exist

On Wed, Jan 17, 2018 at 3:50 PM, Nikolay Shaplov wrote: > This patch raises error if user tries o set or change toast.* option for a > table that does not have a TOST relation. > > I believe it is the only right thing to do, as now if you set toast reloption > for table that