On Tue, 22 Jul 2025 at 10:20, Jacob Champion
wrote:
>
> On Fri, Dec 13, 2024 at 12:54 AM Alexander Kuznetsov
> > 1. slot2 is NULL at line 968,
> > 2. The while loop at line 971 executes once, filling slot1 (slot2 still
> > remains NULL),
> > 3. No changes occur to slot2 thereafter, up to line 100
On Fri, Dec 13, 2024 at 12:54 AM Alexander Kuznetsov
wrote:
> ping. What do you think about reasoning below? Maybe we should consider
> proposing different patch for removing redundant check there?
To move this forward a bit, your reasoning:
> 1. slot2 is NULL at line 968,
> 2. The while loop at
В письме от пятница, 13 декабря 2024 г. 11:54:35 MSK пользователь Alexander
Kuznetsov написал:
> Hello,
>
> ping. What do you think about reasoning below? Maybe we should consider
> proposing different patch for removing redundant check there?
Hi!
Please, pay attention that commitfest entry for
Hello,
ping. What do you think about reasoning below? Maybe we should consider
proposing different patch for removing redundant check there?
09.10.2024 18:23, Alexander Kuznetsov wrote:
03.10.2024 12:48, Daniel Gustafsson wrote:
From a quick reading we can only reach there after evaluating an
03.10.2024 12:48, Daniel Gustafsson wrote:
From a quick reading we can only reach there after evaluating an expression, so
can it really be null though? This code hasn't changed all that much since
2009, if there was a reachable segfault on a null pointer deref I have a
feeling we'd heard about
> On 3 Oct 2024, at 09:47, Alexander Kuznetsov wrote:
>
> Hello everyone,
>
> I'd like to propose adding check for nullness of
> TupleTableSlot before dereferencing it in /src/backend/executor/nodeAgg.c
>
> It is done in the same manner other TupleTableSlots are checked,
> but was probably left