Re: [PATCH] Combine same ternary types in GIN and TSearch

2020-11-13 Thread Tom Lane
Heikki Linnakangas writes: > On 13/11/2020 11:04, Pavel Borisov wrote: >> For historical reasons, now we have two differently named but similar >> ternary data types in TSearch and Gin text-related types. Before v13 >> there was also Gin's private TS_execute() version, from which we >>

Re: [PATCH] Combine same ternary types in GIN and TSearch

2020-11-13 Thread Pavel Borisov
> > GIN is not just for full-text search, so using TSTernaryValue in > GinScanKeyData is wrong. And it would break existing extensions. > > I didn't look much further than that, but I've got a feeling that > combining those is a bad idea. TSTernaryValue is used in text-search > code, even when

Re: [PATCH] Combine same ternary types in GIN and TSearch

2020-11-13 Thread Heikki Linnakangas
On 13/11/2020 11:04, Pavel Borisov wrote: Hi, hackers! For historical reasons, now we have two differently named but similar ternary data types in TSearch and Gin text-related types. Before v13 there was also Gin's private TS_execute() version, from which we eventually shifted to Tsearch's