Re: [PATCH] Initial progress reporting for COPY command

čt 17. 9. 2020 v 7:09 odesílatel Michael Paquier napsal: > > On Mon, Sep 07, 2020 at 01:13:10PM +0900, Michael Paquier wrote: > > Josef, the patch has been waiting on author for a bit more than one > > month, so could you send a rebased version please? It looks that you > > are still a bit confus

Re: [PATCH] Initial progress reporting for COPY command

On Mon, Sep 07, 2020 at 01:13:10PM +0900, Michael Paquier wrote: > Josef, the patch has been waiting on author for a bit more than one > month, so could you send a rebased version please? It looks that you > are still a bit confused by the commit fest process, and as a first > step we need a clean

Re: [PATCH] Initial progress reporting for COPY command

On Thu, Jul 30, 2020 at 08:51:36AM +0900, Fujii Masao wrote: > Yeah, since I read this message, I was thinking that new patch will be > posted. But, Josef, if the situation was changed, could you correct me? > Anyway the patch seems not to be applied cleanly, so at least it needs to > be updated to

Re: [PATCH] Initial progress reporting for COPY command

On 2020/07/29 3:30, Pavel Stehule wrote: út 28. 7. 2020 v 20:25 odesílatel Josef Šimánek mailto:josef.sima...@gmail.com>> napsal: Thanks for the info. I am waiting for review. Is there any summary of requested changes needed? Maybe it is just noise - you wrote so you will resend a pa

Re: [PATCH] Initial progress reporting for COPY command

út 28. 7. 2020 v 20:25 odesílatel Josef Šimánek napsal: > Thanks for the info. I am waiting for review. Is there any summary of > requested changes needed? > Maybe it is just noise - you wrote so you will resend a patch to different thread > >> I tried to reattach the thread there. I'll prepare

Re: [PATCH] Initial progress reporting for COPY command

Thanks for the info. I am waiting for review. Is there any summary of requested changes needed? Dne út 28. 7. 2020 19:00 uživatel Fujii Masao napsal: > > > On 2020/07/02 21:51, Daniel Gustafsson wrote: > >> On 2 Jul 2020, at 14:42, Josef Šimánek wrote: > >> čt 2. 7. 2020 v 14:25 odesílatel Dani

Re: [PATCH] Initial progress reporting for COPY command

On 2020/07/02 21:51, Daniel Gustafsson wrote: On 2 Jul 2020, at 14:42, Josef Šimánek wrote: čt 2. 7. 2020 v 14:25 odesílatel Daniel Gustafsson mailto:dan...@yesql.se>> napsal: The automated patchtester for the Commitfest gets confused when there are two versions of the same changeset attac

Re: [PATCH] Initial progress reporting for COPY command

> On 2 Jul 2020, at 14:42, Josef Šimánek wrote: > čt 2. 7. 2020 v 14:25 odesílatel Daniel Gustafsson > napsal: > The automated patchtester for the Commitfest gets confused when there are two > versions of the same changeset attached to the email, as it tries to apply > t

Re: [PATCH] Initial progress reporting for COPY command

čt 2. 7. 2020 v 14:25 odesílatel Daniel Gustafsson napsal: > The automated patchtester for the Commitfest gets confused when there are > two > versions of the same changeset attached to the email, as it tries to apply > them > both which obviously results in an application failure. I've attached

Re: [PATCH] Initial progress reporting for COPY command

The automated patchtester for the Commitfest gets confused when there are two versions of the same changeset attached to the email, as it tries to apply them both which obviously results in an application failure. I've attached just the previously submitted patch version to this email to see if we

Re: [PATCH] Initial progress reporting for COPY command

On Tue, Jun 23, 2020 at 4:45 PM Tomas Vondra wrote: > > >> > >> Anyway if you would like to make this view more user-friendly, I can add > >> that. Just ping me. > > > >I felt we could add pg_size_pretty to make the view more user friendly. > > > > Please no. That'd make processing of the data (s

Re: [PATCH] Initial progress reporting for COPY command

On 2020/06/22 21:14, Tomas Vondra wrote: On Sun, Jun 21, 2020 at 01:40:34PM +0200, Josef Šimánek wrote: Thanks for all comments. I have updated code to support more options (including STDIN/STDOUT) and added some documentation. Patch is attached and can be found also at https://github.com/si

Re: [PATCH] Initial progress reporting for COPY command

On 2020/06/22 17:21, Josef Šimánek wrote: po 22. 6. 2020 v 4:48 odesílatel Fujii Masao mailto:masao.fu...@oss.nttdata.com>> napsal: On 2020/06/21 20:33, Josef Šimánek wrote: > > > po 15. 6. 2020 v 6:39 odesílatel Fujii Masao mailto:masao.fu...@oss.nttdata.com>

Re: [PATCH] Initial progress reporting for COPY command

> po 15. 6. 2020 v 7:34 odesílatel Bharath Rupireddy > napsal: >> >> > I'm using ftell to get current position in file to populate >> > file_bytes_processed without error handling (ftell can return -1L and also >> > populate errno on problems). >> > >> > 1. Is that a good way to get progress of

Re: [PATCH] Initial progress reporting for COPY command

út 23. 6. 2020 v 13:15 odesílatel Tomas Vondra napsal: > On Tue, Jun 23, 2020 at 03:40:08PM +0530, vignesh C wrote: > >On Mon, Jun 22, 2020 at 4:28 PM Josef Šimánek > wrote: > >> > >> Thanks for the hint regarding "CopyReadLineText". I'll take a look. > >> > >> For now I have tested those cases:

Re: [PATCH] Initial progress reporting for COPY command

út 23. 6. 2020 v 13:15 odesílatel Tomas Vondra napsal: > On Tue, Jun 23, 2020 at 03:40:08PM +0530, vignesh C wrote: > >On Mon, Jun 22, 2020 at 4:28 PM Josef Šimánek > wrote: > >> > >> Thanks for the hint regarding "CopyReadLineText". I'll take a look. > >> > >> For now I have tested those cases:

Re: [PATCH] Initial progress reporting for COPY command

On Tue, Jun 23, 2020 at 03:40:08PM +0530, vignesh C wrote: On Mon, Jun 22, 2020 at 4:28 PM Josef Šimánek wrote: Thanks for the hint regarding "CopyReadLineText". I'll take a look. For now I have tested those cases: CREATE TABLE test(id int); INSERT INTO test SELECT 1 FROM generate_series(1,

Re: [PATCH] Initial progress reporting for COPY command

On Mon, Jun 22, 2020 at 4:28 PM Josef Šimánek wrote: > > Thanks for the hint regarding "CopyReadLineText". I'll take a look. > > For now I have tested those cases: > > CREATE TABLE test(id int); > INSERT INTO test SELECT 1 FROM generate_series(1, 100); > COPY (SELECT * FROM test) TO '/tmp/ids'

Re: [PATCH] Initial progress reporting for COPY command

On Mon, Jun 22, 2020 at 03:33:00PM +0200, Josef Šimánek wrote: po 22. 6. 2020 v 14:14 odesílatel Tomas Vondra napsal: On Sun, Jun 21, 2020 at 01:40:34PM +0200, Josef Šimánek wrote: >Thanks for all comments. I have updated code to support more options >(including STDIN/STDOUT) and added some do

Re: [PATCH] Initial progress reporting for COPY command

po 22. 6. 2020 v 14:14 odesílatel Tomas Vondra napsal: > On Sun, Jun 21, 2020 at 01:40:34PM +0200, Josef Šimánek wrote: > >Thanks for all comments. I have updated code to support more options > >(including STDIN/STDOUT) and added some documentation. > > > >Patch is attached and can be found also

Re: [PATCH] Initial progress reporting for COPY command

On Sun, Jun 21, 2020 at 01:40:34PM +0200, Josef Šimánek wrote: Thanks for all comments. I have updated code to support more options (including STDIN/STDOUT) and added some documentation. Patch is attached and can be found also at https://github.com/simi/postgres/pull/5. Diff version: https://gi

Re: [PATCH] Initial progress reporting for COPY command

po 22. 6. 2020 v 9:15 odesílatel vignesh C napsal: > On Sun, Jun 21, 2020 at 5:11 PM Josef Šimánek > wrote: > > > > Thanks for all comments. I have updated code to support more options > (including STDIN/STDOUT) and added some documentation. > > > > Patch is attached and can be found also at > h

Re: [PATCH] Initial progress reporting for COPY command

po 22. 6. 2020 v 4:48 odesílatel Fujii Masao napsal: > > > On 2020/06/21 20:33, Josef Šimánek wrote: > > > > > > po 15. 6. 2020 v 6:39 odesílatel Fujii Masao < > masao.fu...@oss.nttdata.com > napsal: > > > > > > > > On 2020/06/14 21:32, Josef Šimánek wrote:

Re: [PATCH] Initial progress reporting for COPY command

On Sun, Jun 21, 2020 at 5:11 PM Josef Šimánek wrote: > > Thanks for all comments. I have updated code to support more options > (including STDIN/STDOUT) and added some documentation. > > Patch is attached and can be found also at > https://github.com/simi/postgres/pull/5. > > Diff version: https

Re: [PATCH] Initial progress reporting for COPY command

On 2020/06/21 20:33, Josef Šimánek wrote: po 15. 6. 2020 v 6:39 odesílatel Fujii Masao mailto:masao.fu...@oss.nttdata.com>> napsal: On 2020/06/14 21:32, Josef Šimánek wrote: > Hello, as proposed by Pavel Stěhule and discussed on local czech PostgreSQL maillist (https://groups.g

Re: [PATCH] Initial progress reporting for COPY command

po 15. 6. 2020 v 7:34 odesílatel Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> napsal: > > I'm using ftell to get current position in file to populate > file_bytes_processed without error handling (ftell can return -1L and also > populate errno on problems). > > > > 1. Is that a good

Re: [PATCH] Initial progress reporting for COPY command

po 15. 6. 2020 v 2:18 odesílatel Michael Paquier napsal: > Hi Josef, > > On Sun, Jun 14, 2020 at 02:32:33PM +0200, Josef Šimánek wrote: > > Hello, as proposed by Pavel Stěhule and discussed on local czech > PostgreSQL > > maillist ( > > > https://groups.google.com/d/msgid/postgresql-cz/CAFj8pRCZ4

Re: [PATCH] Initial progress reporting for COPY command

po 15. 6. 2020 v 6:39 odesílatel Fujii Masao napsal: > > > On 2020/06/14 21:32, Josef Šimánek wrote: > > Hello, as proposed by Pavel Stěhule and discussed on local czech > PostgreSQL maillist ( > https://groups.google.com/d/msgid/postgresql-cz/CAFj8pRCZ42CBCa1bPHr7htffSV%2BNAcgcHHG0dVqOog4bsu2LFw

Re: [PATCH] Initial progress reporting for COPY command

po 15. 6. 2020 v 2:18 odesílatel Michael Paquier napsal: > Hi Josef, > > On Sun, Jun 14, 2020 at 02:32:33PM +0200, Josef Šimánek wrote: > > Hello, as proposed by Pavel Stěhule and discussed on local czech > PostgreSQL > > maillist ( > > > https://groups.google.com/d/msgid/postgresql-cz/CAFj8pRCZ4

Re: [PATCH] Initial progress reporting for COPY command

> I'm using ftell to get current position in file to populate > file_bytes_processed without error handling (ftell can return -1L and also > populate errno on problems). > > 1. Is that a good way to get progress of file processing? IMO, it's better to handle the error cases. One possible case wh

Re: [PATCH] Initial progress reporting for COPY command

On 2020/06/14 21:32, Josef Šimánek wrote: Hello, as proposed by Pavel Stěhule and discussed on local czech PostgreSQL maillist (https://groups.google.com/d/msgid/postgresql-cz/CAFj8pRCZ42CBCa1bPHr7htffSV%2BNAcgcHHG0dVqOog4bsu2LFw%40mail.gmail.com?utm_medium=email&utm_source=footer), I have

Re: [PATCH] Initial progress reporting for COPY command

Hi Josef, On Sun, Jun 14, 2020 at 02:32:33PM +0200, Josef Šimánek wrote: > Hello, as proposed by Pavel Stěhule and discussed on local czech PostgreSQL > maillist ( > https://groups.google.com/d/msgid/postgresql-cz/CAFj8pRCZ42CBCa1bPHr7htffSV%2BNAcgcHHG0dVqOog4bsu2LFw%40mail.gmail.com?utm_medium=em