Re: [PATCH] ProcessInterrupts_hook

2021-10-11 Thread Craig Ringer
On Sat, 2 Oct 2021 at 01:24, Jaime Casanova wrote: > On Tue, Jun 29, 2021 at 01:32:26PM +0800, Craig Ringer wrote: > > On Sat, 20 Mar 2021 at 03:46, Tom Lane wrote: > > > > > Robert Haas writes: > > > > On Fri, Mar 19, 2021 at 3:25 PM Tom Lane wrote: > > > >> I'm not very comfortable about the

Re: [PATCH] ProcessInterrupts_hook

2021-10-01 Thread Jaime Casanova
On Tue, Jun 29, 2021 at 01:32:26PM +0800, Craig Ringer wrote: > On Sat, 20 Mar 2021 at 03:46, Tom Lane wrote: > > > Robert Haas writes: > > > On Fri, Mar 19, 2021 at 3:25 PM Tom Lane wrote: > > >> I'm not very comfortable about the idea of having the postmaster set > > >> child processes' latch

Re: [PATCH] ProcessInterrupts_hook

2021-06-28 Thread Craig Ringer
On Sat, 20 Mar 2021 at 03:46, Tom Lane wrote: > Robert Haas writes: > > On Fri, Mar 19, 2021 at 3:25 PM Tom Lane wrote: > >> I'm not very comfortable about the idea of having the postmaster set > >> child processes' latches ... that doesn't sound terribly safe from the > >> standpoint of not al

Re: [PATCH] ProcessInterrupts_hook

2021-03-19 Thread Tom Lane
Robert Haas writes: > On Fri, Mar 19, 2021 at 3:25 PM Tom Lane wrote: >> I'm not very comfortable about the idea of having the postmaster set >> child processes' latches ... that doesn't sound terribly safe from the >> standpoint of not allowing the postmaster to mess with shared memory >> state

Re: [PATCH] ProcessInterrupts_hook

2021-03-19 Thread Robert Haas
On Fri, Mar 19, 2021 at 3:25 PM Tom Lane wrote: > David Steele writes: > > On 1/19/21 1:42 AM, Craig Ringer wrote: > >> My suggestion, which I'm happy to post in patch form if you think it's > >> reasonable > > > Tom, Robert, and thoughts on the proposals in [1]? > > https://www.postgresql.org/m

Re: [PATCH] ProcessInterrupts_hook

2021-03-19 Thread Tom Lane
David Steele writes: > On 1/19/21 1:42 AM, Craig Ringer wrote: >> My suggestion, which I'm happy to post in patch form if you think it's >> reasonable > Tom, Robert, and thoughts on the proposals in [1]? > https://www.postgresql.org/message-id/CAGRY4nyNfscmQiZBCNT7cBYnQxJLAAVCGz%2BGZAQDAco1Fbb0

Re: [PATCH] ProcessInterrupts_hook

2021-03-19 Thread David Steele
On 1/19/21 1:42 AM, Craig Ringer wrote: On Tue, 19 Jan 2021 at 12:44, Craig Ringer mailto:craig.rin...@enterprisedb.com>> wrote: > We're about halfway there already, see 7e784d1dc.  I didn't do the > other half because it wasn't necessary to the problem, but e

Re: [PATCH] ProcessInterrupts_hook

2021-01-18 Thread Craig Ringer
On Tue, 19 Jan 2021 at 12:44, Craig Ringer wrote: > > > We're about halfway there already, see 7e784d1dc. I didn't do the >> > other half because it wasn't necessary to the problem, but exposing >> > the shutdown state more fully seems reasonable. >> > > Excellent, I'll take a look. Thanks. > T

Re: [PATCH] ProcessInterrupts_hook

2021-01-18 Thread Craig Ringer
On Tue, 19 Jan 2021, 02:01 Robert Haas, wrote: > On Mon, Jan 18, 2021 at 11:56 AM Tom Lane wrote: > > > I've wanted this in the past, too, so +1 from me. > > > > I dunno, this seems pretty scary and easily abusable. There's not all > > that much that can be done safely in ProcessInterrupts(), a

Re: [PATCH] ProcessInterrupts_hook

2021-01-18 Thread Robert Haas
On Mon, Jan 18, 2021 at 11:56 AM Tom Lane wrote: > > I've wanted this in the past, too, so +1 from me. > > I dunno, this seems pretty scary and easily abusable. There's not all > that much that can be done safely in ProcessInterrupts(), and we should > not be encouraging extensions to think they

Re: [PATCH] ProcessInterrupts_hook

2021-01-18 Thread Tom Lane
Robert Haas writes: > On Mon, Jan 18, 2021 at 3:00 AM Craig Ringer > wrote: >> A few times lately I've been doing things in extensions that've made me want >> to be able to run my own code whenever InterruptPending is true and >> CHECK_FOR_INTERRUPTS() calls ProcessInterrupts() > I've wanted t

Re: [PATCH] ProcessInterrupts_hook

2021-01-18 Thread Robert Haas
On Mon, Jan 18, 2021 at 3:00 AM Craig Ringer wrote: > A few times lately I've been doing things in extensions that've made me want > to be able to run my own code whenever InterruptPending is true and > CHECK_FOR_INTERRUPTS() calls ProcessInterrupts() I've wanted this in the past, too, so +1 fr