Re: [PATCH] Support for basic ALTER TABLE progress reporting.

2025-07-08 Thread jian he
hi. within ATRewriteTable we have: pgstat_progress_update_param(PROGRESS_CLUSTER_TOTAL_HEAP_BLKS, RelationGetNumberOfBlocks(oldrel)); pgstat_progress_update_param(PROGRESS_CLUSTER_TOTAL_HEAP_BLKS, heapScan->rs_nblocks); PROGRESS_CLUSTER_TOTAL_HE

Re: [PATCH] Support for basic ALTER TABLE progress reporting.

2025-06-30 Thread Jiří Kavalík
Hi, thank you for the review! On Fri, Jun 6, 2025 at 10:37 AM jian he wrote: > On Mon, Jun 2, 2025 at 3:35 PM Jiří Kavalík wrote: > > What I changed: > > > > `commands/tablecmds.c` > > - start and end reporting inside `ATRewriteTables()` > > - report blocks total, blocks and tuples scanned and

Re: [PATCH] Support for basic ALTER TABLE progress reporting.

2025-06-06 Thread jian he
On Mon, Jun 2, 2025 at 3:35 PM Jiří Kavalík wrote: > What I changed: > > `commands/tablecmds.c` > - start and end reporting inside `ATRewriteTables()` > - report blocks total, blocks and tuples scanned and possibly tuples written > in `ATRewriteTable` > - add at least phase info in `validateForei