Re: [PATCH] fix compilation with gnu89

2020-11-29 Thread Tom Lane
Andres Freund writes: > On 2020-11-29 20:33:41 -0800, Rosen Penev wrote: >> GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions. > We require C99 support since postgres 12, and configure should end up > choosing flags to make the compiler support that if possible. Hmm, yeah, tha

Re: [PATCH] fix compilation with gnu89

2020-11-29 Thread Tom Lane
Rosen Penev writes: > GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions. Project policy now is to require C99 support, so the correct solution for using an older compiler is to do something like ./configure CC="gcc -std=gnu99" ... We're not going to accept patches to remove d

Re: [PATCH] fix compilation with gnu89

2020-11-29 Thread Andres Freund
Hi, On 2020-11-29 20:33:41 -0800, Rosen Penev wrote: > GCC 4.8.5 does not default to gnu99 or gnu11 like the newer versions. We require C99 support since postgres 12, and configure should end up choosing flags to make the compiler support that if possible. As far as I can tell the code you chang