Re: [Patch] add new parameter to pg_replication_origin_session_setup

2025-07-29 Thread Doruk Yilmaz
On Mon, Jul 29, 2025 at 8:13 AM Amit Kapila wrote: > That is true but I still feel there has to be some mechanism where we > can catch and give an ERROR to the user, if it doesn't follow the > same. For example, pg_replication_origin_advance() always allows going > backwards in terms of LSN which

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2025-07-28 Thread Amit Kapila
On Tue, Jul 29, 2025 at 2:43 AM Doruk Yilmaz wrote: > > On Mon, Mar 3, 2025 at 6:39 AM Amit Kapila wrote: > > > > To use replication_origin by multiple processes, one must maintain the > > commit order as we do internally by allowing the leader process to > > wait for the parallel worker to finis

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2025-07-28 Thread Doruk Yilmaz
On Mon, Mar 3, 2025 at 6:39 AM Amit Kapila wrote: > > To use replication_origin by multiple processes, one must maintain the > commit order as we do internally by allowing the leader process to > wait for the parallel worker to finish the commit. See comments atop > replorigin_session_setup(). Now

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2025-03-02 Thread Amit Kapila
On Thu, Jan 9, 2025 at 3:26 AM Euler Taveira wrote: > > On Thu, Aug 15, 2024, at 5:53 PM, Doruk Yilmaz wrote: > > Hello again, > > On Tue, Aug 13, 2024 at 12:48 AM Euler Taveira wrote: > > I'm curious about your use case. Is it just because the internal function > > has a > > different signature

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2025-03-01 Thread Doruk Yilmaz
I noticed that the patch needs rebasing, so here is the rebased version. Hopefully it makes to the commitfest. Doruk Yılmaz From 74a74fd02bce786093c19a23bef9444d0b8ef41d Mon Sep 17 00:00:00 2001 From: Doruk Date: Thu, 15 Aug 2024 23:34:26 +0300 Subject: [PATCH v4] pg_replication_origin_session_se

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2025-01-08 Thread Euler Taveira
On Thu, Aug 15, 2024, at 5:53 PM, Doruk Yilmaz wrote: > Hello again, > > On Tue, Aug 13, 2024 at 12:48 AM Euler Taveira wrote: > > I'm curious about your use case. Is it just because the internal function > > has a > > different signature or your tool is capable of apply logical replication > >

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2024-08-15 Thread Doruk Yilmaz
Hello again, On Tue, Aug 13, 2024 at 12:48 AM Euler Taveira wrote: > I'm curious about your use case. Is it just because the internal function has > a > different signature or your tool is capable of apply logical replication > changes > in parallel using the SQL API? The latter is correct, it

Re: [Patch] add new parameter to pg_replication_origin_session_setup

2024-08-12 Thread Euler Taveira
On Mon, Aug 12, 2024, at 3:43 PM, Doruk Yilmaz wrote: > Hello all, Hi! > While working on our internal tools that utilise replication, we > realised that a new parameter was added to the internal C function > corresponding to pg_replication_origin_session_setup. > However this parameter wasn't in