Re: Add const to values and nulls arguments

2023-10-10 Thread Aleksander Alekseev
Hi, > >> The 0002 patch, which I'm not proposing to commit at this time, makes > >> similar changes but in a way that breaks the table and index AM APIs. > >> So I'm just including that here in case anyone wonders, why didn't you > >> touch those. And also maybe if we ever change that API incompa

Re: Add const to values and nulls arguments

2023-10-09 Thread Peter Eisentraut
On 06.10.23 16:51, Aleksander Alekseev wrote: There are a lot of Datum *values, bool *nulls argument pairs that should really be const. The 0001 patch makes those changes. Some of these hunks depend on each other. The 0002 patch, which I'm not proposing to commit at this time, makes similar ch

Re: Add const to values and nulls arguments

2023-10-06 Thread Aleksander Alekseev
Hi, > There are a lot of Datum *values, bool *nulls argument pairs that should > really be const. The 0001 patch makes those changes. Some of these > hunks depend on each other. > > The 0002 patch, which I'm not proposing to commit at this time, makes > similar changes but in a way that breaks t