Re: Add memory_limit_hits to pg_stat_replication_slots

2025-09-25 Thread Masahiko Sawada
On Thu, Sep 25, 2025 at 3:17 AM Bertrand Drouvot wrote: > > Hi, > > On Wed, Sep 24, 2025 at 10:11:20AM -0700, Masahiko Sawada wrote: > > On Tue, Sep 23, 2025 at 11:31 PM Bertrand Drouvot > > wrote: > > > > Thank you for updating the patch! Here are some comments: > > > > --- > > + boolm

Re: Add memory_limit_hits to pg_stat_replication_slots

2025-09-23 Thread Bertrand Drouvot
On Mon, Sep 22, 2025 at 05:21:35PM +0530, shveta malik wrote: > On Mon, Sep 22, 2025 at 4:35 PM Amit Kapila wrote: > > > > On Mon, Sep 22, 2025 at 1:41 PM Bertrand Drouvot > > wrote: > > > > > > > > > > > Since other statistics counter names are camel cases I think it's > > > > better to follow t

Re: Add memory_limit_hits to pg_stat_replication_slots

2025-09-22 Thread shveta malik
On Mon, Sep 22, 2025 at 4:35 PM Amit Kapila wrote: > > On Mon, Sep 22, 2025 at 1:41 PM Bertrand Drouvot > wrote: > > > > > > > > Since other statistics counter names are camel cases I think it's > > > better to follow that for the new counter. > > > > Makes sense, done with memoryLimitHits in v2

Re: Add memory_limit_hits to pg_stat_replication_slots

2025-09-22 Thread Amit Kapila
On Mon, Sep 22, 2025 at 1:41 PM Bertrand Drouvot wrote: > > > > > Since other statistics counter names are camel cases I think it's > > better to follow that for the new counter. > > Makes sense, done with memoryLimitHits in v2 attached (that's the only change > as compared with v1). > The memory

Re: Add memory_limit_hits to pg_stat_replication_slots

2025-09-22 Thread Bertrand Drouvot
Hi, On Thu, Sep 11, 2025 at 03:24:54PM -0700, Masahiko Sawada wrote: > On Wed, Aug 27, 2025 at 12:26 AM Bertrand Drouvot > wrote: > > > > Looking forward to your feedback, > > Yes, Thanks for looking at it! > it's a quite different situation in two cases: spilling 100 > transactions in one Reo

Re: Add memory_limit_hits to pg_stat_replication_slots

2025-09-11 Thread Masahiko Sawada
On Wed, Aug 27, 2025 at 12:26 AM Bertrand Drouvot wrote: > > Hi hackers, > > I think that it's currently not always possible to determine how many times > logical_decoding_work_mem has been reached. > > For example, say a transaction is made of 40 subtransactions, and I get: > > slot_name | sp