Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts

2021-03-05 Thread Julien Rouhaud
On Fri, Mar 5, 2021 at 9:28 AM Michael Paquier wrote: > > On Thu, Mar 04, 2021 at 06:37:56PM +0100, Juan José Santamaría Flecha wrote: > > LGTM. > > Thanks. I have tested more combinations of options, came back a bit > to the documentation for buildenv.pl where copying the values from the > docs

Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts

2021-03-04 Thread Michael Paquier
On Thu, Mar 04, 2021 at 06:37:56PM +0100, Juan José Santamaría Flecha wrote: > LGTM. Thanks. I have tested more combinations of options, came back a bit to the documentation for buildenv.pl where copying the values from the docs would result in a warning, and applied it. -- Michael

Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts

2021-03-04 Thread Juan José Santamaría Flecha
On Thu, Mar 4, 2021 at 3:11 AM Michael Paquier wrote: > On Wed, Mar 03, 2021 at 08:59:30PM +0100, Juan José Santamaría Flecha > wrote: > > This seems to me as if setting the variables in the shell is the proposed > > way to do so. In the previous doc point we do the same with the > buildenv.pl >

Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts

2021-03-03 Thread Michael Paquier
On Wed, Mar 03, 2021 at 08:59:30PM +0100, Juan José Santamaría Flecha wrote: > This seems to me as if setting the variables in the shell is the proposed > way to do so. In the previous doc point we do the same with the buildenv.pl > file. It looks inconsistent, as if it was one way or the other,

Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts

2021-03-03 Thread Juan José Santamaría Flecha
On Wed, Mar 3, 2021 at 11:25 AM Julien Rouhaud wrote: > On Wed, Mar 03, 2021 at 05:19:22PM +0900, Michael Paquier wrote: > > > > Each time I do development on Windows, I get annoyed by the fact that > > it is not easy to run individual test scripts in the same way as we do > > on any other

Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts

2021-03-03 Thread Julien Rouhaud
On Wed, Mar 03, 2021 at 05:19:22PM +0900, Michael Paquier wrote: > > Each time I do development on Windows, I get annoyed by the fact that > it is not easy to run individual test scripts in the same way as we do > on any other platforms, using PROVE_TESTS, or even PROVE_FLAGS. And > there have