Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-11-21 Thread Fujii Masao
On Wed, Nov 20, 2019 at 1:11 PM btkimurayuzk wrote: > > > Barring any objection, I'm thinking to commit this patch. > > > > Regards, > > Build and All Test has passed . > Looks good to me . Thanks for reviewing the patch! I committed the following two patches. - Allow ALTER VIEW command to renam

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-11-19 Thread btkimurayuzk
Barring any objection, I'm thinking to commit this patch. Regards, Build and All Test has passed . Looks good to me . Regards,

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-11-14 Thread Fujii Masao
On Wed, Nov 6, 2019 at 4:14 PM btfujiitkp wrote: > > 2019-10-31 21:01 に Fujii Masao さんは書きました: > > On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed > > wrote: > >> > >> > >> > >> On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao > >> wrote: > >>> > >>> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote: > >>>

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-11-06 Thread Fujii Masao
On Thu, Oct 31, 2019 at 9:34 PM Ibrar Ahmed wrote: > > > > On Thu, Oct 31, 2019 at 5:28 PM Ibrar Ahmed wrote: >> >> >> >> On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote: >>> >>> >>> >>> On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote: On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-11-05 Thread btfujiitkp
2019-10-31 21:01 に Fujii Masao さんは書きました: On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed wrote: On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao wrote: On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote: > > Fujii Masao writes: > > Currently CREATE OR REPLACE VIEW command fails if the column names

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-31 Thread Fujii Masao
On Thu, Oct 31, 2019 at 10:54 PM Tom Lane wrote: > > Fujii Masao writes: > > On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote: > >> Fujii Masao writes: > >>> Currently CREATE OR REPLACE VIEW command fails if the column names > >>> are changed. > > >> That is, I believe, intentional. It's an effe

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-31 Thread Tom Lane
Fujii Masao writes: > On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote: >> Fujii Masao writes: >>> Currently CREATE OR REPLACE VIEW command fails if the column names >>> are changed. >> That is, I believe, intentional. It's an effective aid to catching >> mistakes in view redefinitions, such as

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-31 Thread Ibrar Ahmed
On Thu, Oct 31, 2019 at 5:28 PM Ibrar Ahmed wrote: > > > On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote: > >> >> >> On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao >> wrote: >> >>> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed >>> wrote: >>> > >>> > >>> > >>> > On Thu, Oct 31, 2019 at 12:32 PM Fu

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-31 Thread Ibrar Ahmed
On Thu, Oct 31, 2019 at 5:11 PM Ibrar Ahmed wrote: > > > On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote: > >> On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed >> wrote: >> > >> > >> > >> > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao >> wrote: >> >> >> >> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-31 Thread Ibrar Ahmed
On Thu, Oct 31, 2019 at 5:01 PM Fujii Masao wrote: > On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed wrote: > > > > > > > > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao > wrote: > >> > >> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote: > >> > > >> > Fujii Masao writes: > >> > > Currently CREATE O

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-31 Thread Fujii Masao
On Thu, Oct 31, 2019 at 7:59 PM Ibrar Ahmed wrote: > > > > On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao wrote: >> >> On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote: >> > >> > Fujii Masao writes: >> > > Currently CREATE OR REPLACE VIEW command fails if the column names >> > > are changed. >> > >

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-31 Thread Ibrar Ahmed
On Thu, Oct 31, 2019 at 12:32 PM Fujii Masao wrote: > On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote: > > > > Fujii Masao writes: > > > Currently CREATE OR REPLACE VIEW command fails if the column names > > > are changed. > > > > That is, I believe, intentional. It's an effective aid to catchi

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-31 Thread Fujii Masao
On Thu, Oct 31, 2019 at 1:42 PM Tom Lane wrote: > > Fujii Masao writes: > > Currently CREATE OR REPLACE VIEW command fails if the column names > > are changed. > > That is, I believe, intentional. It's an effective aid to catching > mistakes in view redefinitions, such as misaligning the new set

Re: Allow CREATE OR REPLACE VIEW to rename the columns

2019-10-30 Thread Tom Lane
Fujii Masao writes: > Currently CREATE OR REPLACE VIEW command fails if the column names > are changed. That is, I believe, intentional. It's an effective aid to catching mistakes in view redefinitions, such as misaligning the new set of columns relative to the old. That's particularly importan