Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-28 Thread Masahiro Ikeda
Thanks for your feedback. I've attached the updated patches. On 2025-05-28 10:10, Fujii Masao wrote: On 2025/05/26 16:55, ikedamsh wrote: 2025/05/21 12:54 Fujii Masao : Regarding the 0002 patch: - errdetail("Relation \"%s\" is a %s index.", -RelationGetRelationName(rel), NameSt

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-27 Thread Fujii Masao
On 2025/05/26 16:55, ikedamsh wrote: 2025/05/21 12:54 Fujii Masao : On Mon, May 19, 2025 at 5:18 PM Masahiro Ikeda wrote: > > Thanks for your work and feedback! > > I've updated the patches and added regular regression tests for > both pg_prewarm and amcheck.

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-26 Thread ikedamsh
2025/05/21 12:54 Fujii Masao :On Mon, May 19, 2025 at 5:18 PM Masahiro Ikeda wrote: > > Thanks for your work and feedback! > > I've updated the patches and added regular regression tests for > both pg_prewarm and amcheck. Thanks for updating the patches! Regarding the 0001 patch: +CR

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-20 Thread Fujii Masao
On Mon, May 19, 2025 at 5:18 PM Masahiro Ikeda wrote: > > Thanks for your work and feedback! > > I've updated the patches and added regular regression tests for > both pg_prewarm and amcheck. Thanks for updating the patches! Regarding the 0001 patch: +CREATE TABLE test_part1 PARTITION OF test F

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-19 Thread Masahiro Ikeda
Thanks for your work and feedback! I've updated the patches and added regular regression tests for both pg_prewarm and amcheck. On 2025-05-16 21:01, Fujii Masao wrote: Also, since the issue was introduced in v17, this patch should be back-patched to v17, right? I agree with back-patching v3-

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-16 Thread Fujii Masao
On 2025/05/16 15:33, Dilip Kumar wrote: On Fri, May 16, 2025 at 11:51 AM Masahiro Ikeda wrote: Thank you for your comments! I updated the patch to use RELKIND_HAS_STORAGE() as done in commit 4623d7144. Please see the v2-0001 patch for the changes. Thanks for updating the patch! You adde

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-15 Thread Dilip Kumar
On Fri, May 16, 2025 at 11:51 AM Masahiro Ikeda wrote: > > Thank you for your comments! > > I updated the patch to use RELKIND_HAS_STORAGE() as done in > commit 4623d7144. Please see the v2-0001 patch for the changes. > > On 2025-05-15 19:57, Richard Guo wrote: > > +1. FWIW, not long ago we fixed

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-15 Thread Masahiro Ikeda
Thank you for your comments! I updated the patch to use RELKIND_HAS_STORAGE() as done in commit 4623d7144. Please see the v2-0001 patch for the changes. On 2025-05-15 19:57, Richard Guo wrote: +1. FWIW, not long ago we fixed a similar Assert failure in contrib/pg_freespacemap by verifying RELK

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-15 Thread Richard Guo
On Thu, May 15, 2025 at 6:50 PM Dilip Kumar wrote: > On Thu, May 15, 2025 at 3:14 PM Fujii Masao > wrote: > > How about adding a check to see whether the target relation has storage, > > using something like RELKIND_HAS_STORAGE()? > Yeah, that makes more sense. +1. FWIW, not long ago we fixed

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-15 Thread Dilip Kumar
On Thu, May 15, 2025 at 3:14 PM Fujii Masao wrote: > > > > On 2025/05/15 18:20, Dilip Kumar wrote: > > On Thu, May 15, 2025 at 2:22 PM Masahiro Ikeda > > wrote: > >> > >> Hi, > >> > >> I encountered an assertion failure when a partitioned table is specified > >> as an argument to pg_prewarm. Bel

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-15 Thread Fujii Masao
On 2025/05/15 18:20, Dilip Kumar wrote: On Thu, May 15, 2025 at 2:22 PM Masahiro Ikeda wrote: Hi, I encountered an assertion failure when a partitioned table is specified as an argument to pg_prewarm. Below are the steps to reproduce the issue: Thanks for the report! This assertion fail

Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables

2025-05-15 Thread Dilip Kumar
On Thu, May 15, 2025 at 2:22 PM Masahiro Ikeda wrote: > > Hi, > > I encountered an assertion failure when a partitioned table is specified > as an argument to pg_prewarm. Below are the steps to reproduce the > issue: > > $ pgbench -i -s 1 --partitions=3 > $ psql < CREATE EXTENSION pg_prewarm; > SE