Re: Avoiding inadvertent debugging mode for pgbench

2024-03-25 Thread Nathan Bossart
Committed. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-21 Thread Nathan Bossart
On Wed, Mar 20, 2024 at 11:57:25AM -0400, Greg Sabino Mullane wrote: > My mistake. Attached please find version 3, which should hopefully make > cfbot happy again. Here is what I have staged for commit. I plan to commit this within the next few days. -- Nathan Bossart Amazon Web Services:

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-21 Thread David Christensen
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed Did a quick review of this one; CFbot is now happy, local

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-20 Thread Greg Sabino Mullane
My mistake. Attached please find version 3, which should hopefully make cfbot happy again. pgbench.dash.d.or.not.dash.d.v3.patch Description: Binary data

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-20 Thread Nathan Bossart
On Tue, Mar 19, 2024 at 09:15:22PM -0400, Greg Sabino Mullane wrote: > Rebased version attached (v2), with another sentence in the sgml to explain > the optional use of -d cfbot seems quite unhappy with this: https://cirrus-ci.com/build/6429518263484416 -- Nathan Bossart Amazon Web

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-19 Thread Greg Sabino Mullane
Rebased version attached (v2), with another sentence in the sgml to explain the optional use of -d Cheers, Greg pgbench.dash.d.or.not.dash.d.v2.patch Description: Binary data

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-19 Thread Nathan Bossart
On Tue, Mar 19, 2024 at 01:47:53PM -0500, Nathan Bossart wrote: > On Mon, Mar 11, 2024 at 04:59:36PM +0100, Alvaro Herrera wrote: >> All in all, I support the original patch. > > I'll commit this in a few days if there are no objections. Actually, I just took a look at the patch and it appears

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-19 Thread Nathan Bossart
On Mon, Mar 11, 2024 at 04:59:36PM +0100, Alvaro Herrera wrote: > All in all, I support the original patch. I'll commit this in a few days if there are no objections. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-11 Thread Alvaro Herrera
On 2024-Mar-01, Euler Taveira wrote: > I don't like to break backward compatibility but in this case I suspect that > it > is ok. I don't recall the last time I saw a script that makes use of -d > option. > How often do you need a pgbench debug information? I wondered what the difference

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-01 Thread Euler Taveira
On Fri, Mar 1, 2024, at 8:07 PM, Tomas Vondra wrote: > On 3/1/24 23:41, Nathan Bossart wrote: > > > > I think this is a generally reasonable proposal, except I don't know > > whether this breakage is acceptable. AFAICT there are two fundamental > > behavior changes folks would observe: > > > >

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-01 Thread Tomas Vondra
On 3/1/24 23:41, Nathan Bossart wrote: > On Thu, Feb 29, 2024 at 07:05:13PM -0500, Greg Sabino Mullane wrote: >> Attached please find a patch to adjust the behavior of the pgbench program >> and make it behave like the other programs that connect to a database >> (namely, psql and pg_dump).

Re: Avoiding inadvertent debugging mode for pgbench

2024-03-01 Thread Nathan Bossart
On Thu, Feb 29, 2024 at 07:05:13PM -0500, Greg Sabino Mullane wrote: > Attached please find a patch to adjust the behavior of the pgbench program > and make it behave like the other programs that connect to a database > (namely, psql and pg_dump). Specifically, add support for using -d and >