Re: Bugfix and improvements in multixact.c

2024-06-16 Thread Heikki Linnakangas
On 14/06/2024 16:56, Maxim Orlov wrote: +static inline int +MXOffsetToFlagsOffset(MultiXactOffset offset) +{ + int flagsoff; + + offset /= MULTIXACT_MEMBERS_PER_MEMBERGROUP; + offset %= MULTIXACT_MEMBERGROUPS_PER_PAGE; + flagsoff = offset * MULTIXACT_MEMBERGROU

Re: Bugfix and improvements in multixact.c

2024-06-14 Thread Heikki Linnakangas
On 14/06/2024 16:56, Maxim Orlov wrote: Hi! While working on a making multix xact offsets 64-bit [0] I've discovered a minor issue. The thing is that type 'xid' is used in all macro, but it doesn't correct. Appropriate MultiXactId or MultiXactOffset should be used, actually. And the second t