Re: Bytea PL/Perl transform

2024-03-21 Thread Tom Lane
Alexander Korotkov writes: > On Tue, Jan 30, 2024 at 8:46 PM Pavel Stehule wrote: >> I marked this patch as ready for committer. > The last version of the patch still provides transform for builtin > type in a separate extension. As discussed upthread such transforms > don't need separate exten

Re: Bytea PL/Perl transform

2024-02-27 Thread Pavel Stehule
út 27. 2. 2024 v 21:03 odesílatel Alexander Korotkov napsal: > Hi! > > On Tue, Jan 30, 2024 at 8:46 PM Pavel Stehule > wrote: > > I marked this patch as ready for committer. > > The last version of the patch still provides transform for builtin > type in a separate extension. As discussed upthr

Re: Bytea PL/Perl transform

2024-02-27 Thread Alexander Korotkov
Hi! On Tue, Jan 30, 2024 at 8:46 PM Pavel Stehule wrote: > I marked this patch as ready for committer. The last version of the patch still provides transform for builtin type in a separate extension. As discussed upthread such transforms don't need separate extensions, and could be provided as

Re: Bytea PL/Perl transform

2024-01-30 Thread Pavel Stehule
Hi út 30. 1. 2024 v 18:35 odesílatel Pavel Stehule napsal: > > > út 30. 1. 2024 v 18:26 odesílatel Dagfinn Ilmari Mannsåker < > ilm...@ilmari.org> napsal: > >> Pavel Stehule writes: >> >> > út 30. 1. 2024 v 17:46 odesílatel Dagfinn Ilmari Mannsåker < >> > ilm...@ilmari.org> napsal: >> > >> >> P

Re: Bytea PL/Perl transform

2024-01-30 Thread Pavel Stehule
út 30. 1. 2024 v 18:26 odesílatel Dagfinn Ilmari Mannsåker < ilm...@ilmari.org> napsal: > Pavel Stehule writes: > > > út 30. 1. 2024 v 17:46 odesílatel Dagfinn Ilmari Mannsåker < > > ilm...@ilmari.org> napsal: > > > >> Pavel Stehule writes: > >> > >> > út 30. 1. 2024 v 17:18 odesílatel Dagfinn I

Re: Bytea PL/Perl transform

2024-01-30 Thread Dagfinn Ilmari Mannsåker
Pavel Stehule writes: > út 30. 1. 2024 v 17:46 odesílatel Dagfinn Ilmari Mannsåker < > ilm...@ilmari.org> napsal: > >> Pavel Stehule writes: >> >> > út 30. 1. 2024 v 17:18 odesílatel Dagfinn Ilmari Mannsåker < >> > ilm...@ilmari.org> napsal: >> > >> >> Pavel Stehule writes: >> >> >> >> > út 30.

Re: Bytea PL/Perl transform

2024-01-30 Thread Pavel Stehule
út 30. 1. 2024 v 17:46 odesílatel Dagfinn Ilmari Mannsåker < ilm...@ilmari.org> napsal: > Pavel Stehule writes: > > > út 30. 1. 2024 v 17:18 odesílatel Dagfinn Ilmari Mannsåker < > > ilm...@ilmari.org> napsal: > > > >> Pavel Stehule writes: > >> > >> > út 30. 1. 2024 v 16:43 odesílatel Dagfinn I

Re: Bytea PL/Perl transform

2024-01-30 Thread Dagfinn Ilmari Mannsåker
Pavel Stehule writes: > út 30. 1. 2024 v 17:18 odesílatel Dagfinn Ilmari Mannsåker < > ilm...@ilmari.org> napsal: > >> Pavel Stehule writes: >> >> > út 30. 1. 2024 v 16:43 odesílatel Dagfinn Ilmari Mannsåker < >> > ilm...@ilmari.org> napsal: >> > >> >> Pavel Stehule writes: >> >> >> >> > I inse

Re: Bytea PL/Perl transform

2024-01-30 Thread Pavel Stehule
út 30. 1. 2024 v 17:18 odesílatel Dagfinn Ilmari Mannsåker < ilm...@ilmari.org> napsal: > Pavel Stehule writes: > > > út 30. 1. 2024 v 16:43 odesílatel Dagfinn Ilmari Mannsåker < > > ilm...@ilmari.org> napsal: > > > >> Pavel Stehule writes: > >> > >> > I inserted perl reference support - hstore_

Re: Bytea PL/Perl transform

2024-01-30 Thread Dagfinn Ilmari Mannsåker
Pavel Stehule writes: > út 30. 1. 2024 v 16:43 odesílatel Dagfinn Ilmari Mannsåker < > ilm...@ilmari.org> napsal: > >> Pavel Stehule writes: >> >> > I inserted perl reference support - hstore_plperl and json_plperl does >> it. >> > >> > +<->/* Dereference references recursively. */ >> > +<->whil

Re: Bytea PL/Perl transform

2024-01-30 Thread Pavel Stehule
út 30. 1. 2024 v 16:43 odesílatel Dagfinn Ilmari Mannsåker < ilm...@ilmari.org> napsal: > Pavel Stehule writes: > > > I inserted perl reference support - hstore_plperl and json_plperl does > it. > > > > +<->/* Dereference references recursively. */ > > +<->while (SvROK(in)) > > +<-><-->in = SvRV(

Re: Bytea PL/Perl transform

2024-01-30 Thread Dagfinn Ilmari Mannsåker
Pavel Stehule writes: > I inserted perl reference support - hstore_plperl and json_plperl does it. > > +<->/* Dereference references recursively. */ > +<->while (SvROK(in)) > +<-><-->in = SvRV(in); That code in hstore_plperl and json_plperl is only relevant because they deal with non-scalar valu

Re: Bytea PL/Perl transform

2024-01-30 Thread Pavel Stehule
Hi so 6. 1. 2024 v 16:51 odesílatel vignesh C napsal: > On Fri, 21 Jul 2023 at 02:59, Ivan Panchenko wrote: > > > > Friday, 14 July 2023, 23:27 +03:00 от Tom Lane : > > > > =?UTF-8?B?SXZhbiBQYW5jaGVua28=?= writes: > > > Четверг, 6 июля 2023, 14:48 +03:00 от Peter Eisentraut < > pe...@eisentrau

Re: Bytea PL/Perl transform

2024-01-06 Thread vignesh C
On Fri, 21 Jul 2023 at 02:59, Ivan Panchenko wrote: > > Friday, 14 July 2023, 23:27 +03:00 от Tom Lane : > > =?UTF-8?B?SXZhbiBQYW5jaGVua28=?= writes: > > Четверг, 6 июля 2023, 14:48 +03:00 от Peter Eisentraut < > > pe...@eisentraut.org >: > >> If the transform deals with a built-in type, then th

Re: Bytea PL/Perl transform

2023-07-20 Thread Ivan Panchenko
>Friday, 14 July 2023, 23:27 +03:00 от Tom Lane : >  >=?UTF-8?B?SXZhbiBQYW5jaGVua28=?= < w...@mail.ru > writes: >> Четверг, 6 июля 2023, 14:48 +03:00 от Peter Eisentraut < >> pe...@eisentraut.org >: >>> If the transform deals with a built-in type, then they should just be >>> added to the respect

Re: Bytea PL/Perl transform

2023-07-14 Thread Tom Lane
=?UTF-8?B?SXZhbiBQYW5jaGVua28=?= writes: > Четверг, 6 июля 2023, 14:48 +03:00 от Peter Eisentraut < pe...@eisentraut.org > >: >> If the transform deals with a built-in type, then they should just be >> added to the respective pl extension directly. > The new extension bytea_plperl can be easily

Re: Bytea PL/Perl transform

2023-07-14 Thread Ivan Panchenko
>Четверг, 6 июля 2023, 14:48 +03:00 от Peter Eisentraut < pe...@eisentraut.org >>: >  >On 22.06.23 22:56, Greg Sabino Mullane wrote: >> * Do all of these transforms need to be their own contrib modules? So >> much duplicated code across contrib/*_plperl already (and *plpython too >> for that matt

Re: Bytea PL/Perl transform

2023-07-06 Thread Peter Eisentraut
On 22.06.23 22:56, Greg Sabino Mullane wrote: * Do all of these transforms need to be their own contrib modules? So much duplicated code across contrib/*_plperl already (and *plpython too for that matter) ... The reason the first transform modules were separate extensions is that they interfa

Re: Bytea PL/Perl transform

2023-06-28 Thread Tom Lane
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes: > Andrew Dunstan writes: >> On 2023-06-22 Th 16:56, Greg Sabino Mullane wrote: >>> * Do all of these transforms need to be their own contrib modules? So >>> much duplicated code across contrib/*_plperl already (and *plpython >>> too for that matt

Re: Bytea PL/Perl transform

2023-06-23 Thread Dagfinn Ilmari Mannsåker
Andrew Dunstan writes: > On 2023-06-22 Th 16:56, Greg Sabino Mullane wrote: >> >> * Do all of these transforms need to be their own contrib modules? So >> much duplicated code across contrib/*_plperl already (and *plpython >> too for that matter) ... >> >> > > Yeah, that's a bit of a mess. Not s

Re: Bytea PL/Perl transform

2023-06-23 Thread Andrew Dunstan
On 2023-06-22 Th 16:56, Greg Sabino Mullane wrote: * Do all of these transforms need to be their own contrib modules? So much duplicated code across contrib/*_plperl already (and *plpython too for that matter) ... Yeah, that's a bit of a mess. Not sure what we can do about it now. chee

Re: Bytea PL/Perl transform

2023-06-22 Thread Greg Sabino Mullane
> > So I decided to propose a simple transform extension to pass bytea as > native Perl octet strings. Quick review, mostly housekeeping things: * Needs a rebase, minor failure on Mkvcbuild.pm * Code needs standardized formatting, esp. bytea_plperl.c * Needs to be meson-i-fied (i.e. add a "meson

Re: Bytea PL/Perl transform

2023-03-22 Thread Иван Панченко
    >Среда, 22 марта 2023, 12:45 +03:00 от Daniel Gustafsson : >  >> On 18 Mar 2023, at 23:25, Иван Панченко < w...@mail.ru > wrote: >> >> Hi, >> PostgreSQL passes bytea arguments to PL/Perl functions as hexadecimal >> strings, which is not only inconvenient, but also memory and time consuming.

Re: Bytea PL/Perl transform

2023-03-22 Thread Daniel Gustafsson
> On 18 Mar 2023, at 23:25, Иван Панченко wrote: > > Hi, > PostgreSQL passes bytea arguments to PL/Perl functions as hexadecimal > strings, which is not only inconvenient, but also memory and time consuming. > So I decided to propose a simple transform extension to pass bytea as native > Perl o