Nathan Bossart writes:
> Committed.
Thanks!
- ilmari
Committed.
--
nathan
On Thu, Jul 25, 2024 at 04:10:37PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Done: https://commitfest.postgresql.org/49/5139/
>
> I've taken the liberty of setting you as the committer, and the target
> version to 17 even though it turns out to be an older bug, since it's
> arguably a follow-on fix
Nathan Bossart writes:
> On Thu, Jul 25, 2024 at 03:49:02PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> Nathan Bossart writes:
>>> However, since it looks like the feature was never actually supported in a
>>> release, and the revert has been in place for over a decade, I think it'd
>>> be reasona
On Thu, Jul 25, 2024 at 03:49:02PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Nathan Bossart writes:
>> However, since it looks like the feature was never actually supported in a
>> release, and the revert has been in place for over a decade, I think it'd
>> be reasonable to remove the tab completio
Nathan Bossart writes:
> On Thu, Jul 25, 2024 at 03:09:09PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> Scratch that, I misread the diff. The tab completion has been there
>> since matviews were added in commit 3bf3ab8c5636, but the restriction on
>> unlogged matviews was added later in commit 3223
On Thu, Jul 25, 2024 at 03:09:09PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Scratch that, I misread the diff. The tab completion has been there
> since matviews were added in commit 3bf3ab8c5636, but the restriction on
> unlogged matviews was added later in commit 3223b25ff73, which failed to
> upd
Dagfinn Ilmari Mannsåker writes:
> px shi writes:
>
>> Hi, I see that materialized view cannot be unlogged now, but when I use
>> psql and type CREATE UNLOGGED, pressing the Tab key for auto-completion
>> suggests `TABLE` and MATERIALIZED VIEW.
>> Shouldn't `MATERIALIZED VIEW ` be suggested?
>
>
px shi writes:
> Hi, I see that materialized view cannot be unlogged now, but when I use
> psql and type CREATE UNLOGGED, pressing the Tab key for auto-completion
> suggests `TABLE` and MATERIALIZED VIEW.
> Shouldn't `MATERIALIZED VIEW ` be suggested?
That's my fault, I added it in commit c951e9
