Re: Cancelling parallel query leads to segfault

2018-02-16 Thread Peter Eisentraut
On 2/14/18 13:56, Andres Freund wrote: > With your example I can reliably trigger the issue if I shut down the > server while the query is running: OK, that way I can see it too. Fix pushed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remot

Re: Cancelling parallel query leads to segfault

2018-02-14 Thread Andres Freund
On 2018-02-12 15:43:49 -0500, Peter Eisentraut wrote: > On 2/6/18 12:06, Andres Freund wrote: > > On 2018-02-06 12:01:08 -0500, Peter Eisentraut wrote: > >> On 2/1/18 20:35, Andres Freund wrote: > >>> On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut > >>> wrote: > Here is a patch t

Re: Cancelling parallel query leads to segfault

2018-02-12 Thread Peter Eisentraut
On 2/6/18 12:06, Andres Freund wrote: > On 2018-02-06 12:01:08 -0500, Peter Eisentraut wrote: >> On 2/1/18 20:35, Andres Freund wrote: >>> On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut >>> wrote: Here is a patch to implement that idea. Do you have a way to test it repeatedl

Re: Cancelling parallel query leads to segfault

2018-02-06 Thread Andres Freund
On 2018-02-06 12:01:08 -0500, Peter Eisentraut wrote: > On 2/1/18 20:35, Andres Freund wrote: > > On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut > > wrote: > >>Here is a patch to implement that idea. Do you have a way to test it > >>repeatedly, or do you just randomly cancel queries?

Re: Cancelling parallel query leads to segfault

2018-02-06 Thread Peter Eisentraut
On 2/1/18 20:35, Andres Freund wrote: > On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut > wrote: >>Here is a patch to implement that idea. Do you have a way to test it >>repeatedly, or do you just randomly cancel queries? > > For me cancelling the long running parallel queries I tried

Re: Cancelling parallel query leads to segfault

2018-02-01 Thread Andres Freund
On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut wrote: >Here is a patch to implement that idea. Do you have a way to test it >repeatedly, or do you just randomly cancel queries? For me cancelling the long running parallel queries I tried reliably triggers the issue. I encountered

Re: Cancelling parallel query leads to segfault

2018-02-01 Thread Peter Eisentraut
On 1/27/18 22:45, Andres Freund wrote: > I think the comment was bad, but the functionality pretty crucial. So I > don't think > In AtAbort_Portals(), remove the code that marks an active portal as > failed. As the comment there already predicted, this doesn't work if > the running com

Re: Cancelling parallel query leads to segfault

2018-01-29 Thread Robert Haas
On Sat, Jan 27, 2018 at 10:45 PM, Andres Freund wrote: > Hi Peter (and others who mucked around with related code), > > While testing another patch I found that cancelling a parallel query on > master segfaults the leader in an interesting manner: ... > It's clearly not OK to recurse back into the