On Fri, Nov 22, 2024 at 3:53 PM Heikki Linnakangas wrote:
> On 22/11/2024 15:56, Erik Nordström wrote:
> > Yes, it solves the issue so it looks good.
> >
> > Just a minor nit: the code uses both blokno as local variable for
> > pending_writes[i].blkno and directly accessing pending_writes[i].blkn
On 22/11/2024 15:56, Erik Nordström wrote:
Yes, it solves the issue so it looks good.
Just a minor nit: the code uses both blokno as local variable for
pending_writes[i].blkno and directly accessing pending_writes[i].blkno.
Maybe it is better to just use the local variable. For example, change
On Fri, Nov 22, 2024 at 2:26 PM Heikki Linnakangas wrote:
> On 22/11/2024 15:02, Matthias van de Meent wrote:
> > I think I'd go with a patch like attached, where the bulk writer
> > registers that it started with .relsize pages in the relfork, and use
> > that for smgrextend() decisions. It now
On 22/11/2024 15:02, Matthias van de Meent wrote:
I think I'd go with a patch like attached, where the bulk writer
registers that it started with .relsize pages in the relfork, and use
that for smgrextend() decisions. It now also records pages_written as
a separate but accurate value.
Looks goo
On Fri, 22 Nov 2024 at 09:11, Erik Nordström wrote:
>
>
>
> On Fri, Nov 22, 2024 at 12:30 AM Matthias van de Meent
> wrote:
>>
>> On Thu, 21 Nov 2024, 17:18 Erik Nordström, wrote:
>>>
>>> Hello,
>>>
>>> I've noticed a change in behavior of the heap rewrite functionality in
>>> PostgreSQL 17, u
On Fri, Nov 22, 2024 at 12:30 AM Matthias van de Meent <
boekewurm+postg...@gmail.com> wrote:
> On Thu, 21 Nov 2024, 17:18 Erik Nordström, wrote:
>
>> Hello,
>>
>> I've noticed a change in behavior of the heap rewrite functionality in
>> PostgreSQL 17, used by, e.g., CLUSTER. I've been experiment
On Thu, 21 Nov 2024, 17:18 Erik Nordström, wrote:
> Hello,
>
> I've noticed a change in behavior of the heap rewrite functionality in
> PostgreSQL 17, used by, e.g., CLUSTER. I've been experimenting with the
> functionality to implement a way to merge partitions in TimescaleDB. I am
> using table
