Re: Crash in partition-wise join involving dummy partitioned relation

2018-02-06 Thread Robert Haas
On Mon, Feb 5, 2018 at 11:02 PM, Ashutosh Bapat wrote: > The comment says why it checks both bounds and part_scheme, but it > doesn't explain why we check nparts, part_rels etc. My patch had that > explanation. Hmm, well, I couldn't understand it from your comment. I'm fine with adding more expl

Re: Crash in partition-wise join involving dummy partitioned relation

2018-02-05 Thread Ashutosh Bapat
On Tue, Feb 6, 2018 at 4:04 AM, Robert Haas wrote: > On Mon, Feb 5, 2018 at 4:46 AM, Ashutosh Bapat > wrote: >> Here's patch taking that approach. > > I rewrote the comment in relation.h like this, which I think is more clear: > > /* > * Is given relation partitioned? > * > - * A join betwee

Re: Crash in partition-wise join involving dummy partitioned relation

2018-02-05 Thread Robert Haas
On Mon, Feb 5, 2018 at 4:46 AM, Ashutosh Bapat wrote: > Here's patch taking that approach. I rewrote the comment in relation.h like this, which I think is more clear: /* * Is given relation partitioned? * - * A join between two partitioned relations with same partitioning scheme - * without