Re: Fix C4819 warning in MSVC

2021-11-01 Thread Daniel Gustafsson
> On 1 Nov 2021, at 17:12, Tom Lane wrote: > > Daniel Gustafsson writes: >> On 1 Nov 2021, at 14:56, Tom Lane wrote: >>> +1, but there are also C4819 warnings in fe_utils/print.c. Can we get >>> rid of that too? That one's a bit more integral to the code, since >>> (I think) it's complaining

Re: Fix C4819 warning in MSVC

2021-11-01 Thread Tom Lane
Daniel Gustafsson writes: > On 1 Nov 2021, at 14:56, Tom Lane wrote: >> +1, but there are also C4819 warnings in fe_utils/print.c. Can we get >> rid of that too? That one's a bit more integral to the code, since >> (I think) it's complaining about the comments in the unicode_style table. >> But

Re: Fix C4819 warning in MSVC

2021-11-01 Thread Daniel Gustafsson
> On 1 Nov 2021, at 14:56, Tom Lane wrote: > > Daniel Gustafsson writes: >> Reading 1051867.1635720...@sss.pgh.pa.us I noticed that hamerkop raise a >> C4819 >> warning on brin_bloom.c, which is defined as: >> "The file contains a character that cannot be represented in the current >>code

Re: Fix C4819 warning in MSVC

2021-11-01 Thread Tom Lane
Daniel Gustafsson writes: > Reading 1051867.1635720...@sss.pgh.pa.us I noticed that hamerkop raise a C4819 > warning on brin_bloom.c, which is defined as: >"The file contains a character that cannot be represented in the current > code page (number). Save the file in Unicode format to pre