Richard Guo 于2025年10月16日周四 17:53写道：
> On Thu, Oct 16, 2025 at 4:07 PM Xuneng Zhou wrote:
> > On Mon, Sep 1, 2025 at 9:26 AM Chao Li wrote:
> > > On Aug 30, 2025, at 14:09, Tender Wang wrote:
> > > While debugging the HashJoin codes, I noticed below codes in
> ExecHashJoinImpl():
> > >
> > > el
> On Oct 17, 2025, at 12:20, Tender Wang wrote:
>
>
>
> Xuneng Zhou 于2025年10月17日周五 10:31写道：
> Hi Tender,
>
> On Thu, Oct 16, 2025 at 8:24 PM Tender Wang wrote:
> >
> >
> >
> > Richard Guo 于2025年10月16日周四 17:53写道：
> >>
> >> On Thu, Oct 16, 2025 at 4:07 PM Xuneng Zhou wrote:
> >> > On Mon,
Hi,
On Mon, Sep 1, 2025 at 9:26 AM Chao Li wrote:
>
>
>
> On Aug 30, 2025, at 14:09, Tender Wang wrote:
>
> Hi,
>
> While debugging the HashJoin codes, I noticed below codes in
> ExecHashJoinImpl():
>
> elog(ERROR, "unrecognized hashjoin state: %d",
> (int) node->hj_JoinState);
>
> The type of
Hi Richard
> (These values represent the state of the Join state machine for
> HashJoin and MergeJoin respectively, so I kind of wonder if it might
> be better to define them as enum rather than using int.)
Agree +1 ,enum is safer because it has a fixed set of predefined values,
whereas int has a m
Xuneng Zhou 于2025年10月17日周五 10:31写道：
> Hi Tender,
>
> On Thu, Oct 16, 2025 at 8:24 PM Tender Wang wrote:
> >
> >
> >
> > Richard Guo 于2025年10月16日周四 17:53写道：
> >>
> >> On Thu, Oct 16, 2025 at 4:07 PM Xuneng Zhou
> wrote:
> >> > On Mon, Sep 1, 2025 at 9:26 AM Chao Li
> wrote:
> >> > > On Aug 30,
Hi Tender,
On Thu, Oct 16, 2025 at 8:24 PM Tender Wang wrote:
>
>
>
> Richard Guo 于2025年10月16日周四 17:53写道：
>>
>> On Thu, Oct 16, 2025 at 4:07 PM Xuneng Zhou wrote:
>> > On Mon, Sep 1, 2025 at 9:26 AM Chao Li wrote:
>> > > On Aug 30, 2025, at 14:09, Tender Wang wrote:
>> > > While debugging the
On Thu, Oct 16, 2025 at 4:07 PM Xuneng Zhou wrote:
> On Mon, Sep 1, 2025 at 9:26 AM Chao Li wrote:
> > On Aug 30, 2025, at 14:09, Tender Wang wrote:
> > While debugging the HashJoin codes, I noticed below codes in
> > ExecHashJoinImpl():
> >
> > elog(ERROR, "unrecognized hashjoin state: %d",
>
> On Aug 30, 2025, at 14:09, Tender Wang wrote:
>
> Hi,
>
> While debugging the HashJoin codes, I noticed below codes in
> ExecHashJoinImpl():
>
> elog(ERROR, "unrecognized hashjoin state: %d",
> (int) node->hj_JoinState);
>
> The type of hj_JoinState is already int, so the cast seems unnec
