Re: Fix use of openssl.path() if openssl isn't found

2023-11-08 Thread Tristan Partin
On Wed Nov 8, 2023 at 2:31 AM CST, Michael Paquier wrote: On Wed, Nov 08, 2023 at 12:07:49AM -0600, Tristan Partin wrote: >'with_ssl': ssl_library, > - 'OPENSSL': openssl.path(), > + 'OPENSSL': openssl.found() ? openssl.path : '', Except that this was incorrect. I've fixed the

Re: Fix use of openssl.path() if openssl isn't found

2023-11-08 Thread Michael Paquier
On Wed, Nov 08, 2023 at 12:07:49AM -0600, Tristan Partin wrote: >'with_ssl': ssl_library, > - 'OPENSSL': openssl.path(), > + 'OPENSSL': openssl.found() ? openssl.path : '', Except that this was incorrect. I've fixed the grammar and applied that down to 16. -- Michael signature

Re: Fix use of openssl.path() if openssl isn't found

2023-11-07 Thread Tristan Partin
On Tue Nov 7, 2023 at 11:53 PM CST, Michael Paquier wrote: On Tue, Nov 07, 2023 at 04:06:56PM -0600, Tristan Partin wrote: > Found this issue during my Fedora 39 upgrade. Tested that uninstalling > openssl still allows the various ssl tests to run and succeed. Good catch. You are right that thi

Re: Fix use of openssl.path() if openssl isn't found

2023-11-07 Thread Michael Paquier
On Tue, Nov 07, 2023 at 04:06:56PM -0600, Tristan Partin wrote: > Found this issue during my Fedora 39 upgrade. Tested that uninstalling > openssl still allows the various ssl tests to run and succeed. Good catch. You are right that this is inconsistent with what we expect in the test. > +openss