Re: Flexible configuration for full-text search

2019-02-03 Thread Michael Paquier
On Thu, Nov 29, 2018 at 02:02:16PM +0100, Dmitry Dolgov wrote: > Maybe it would be better if you or some of your colleagues (Alexander, > Arthur?) > will post this new version, because the current one has some conflicts - so it > would be easier for a reviewers. For now I'll move it to the next CF

Re: Flexible configuration for full-text search

2018-11-29 Thread Dmitry Dolgov
> On Wed, Aug 29, 2018 at 10:38 AM Aleksandr Parfenov > wrote: > > On Tue, 28 Aug 2018 12:40:32 +0700 > Aleksandr Parfenov wrote: > > >On Fri, 24 Aug 2018 18:50:38 +0300 > >Alexander Korotkov wrote: > >>Agreed, backward compatibility is important here. Probably we should > >>leave old dictiona

Re: Flexible configuration for full-text search

2018-09-11 Thread Tom Lane
Aleksandr Parfenov writes: > As I wrote few weeks ago, there is a issue with stopwords processing in > proposed syntax for full-text configurations. I want to separate word > normalization and stopwords detection to two separate dictionaries. The > problem is how to configure stopword detection di

Re: Flexible configuration for full-text search

2018-09-11 Thread Aleksandr Parfenov
Hello hackers! As I wrote few weeks ago, there is a issue with stopwords processing in proposed syntax for full-text configurations. I want to separate word normalization and stopwords detection to two separate dictionaries. The problem is how to configure stopword detection dictionary. The cause

Re: Flexible configuration for full-text search

2018-08-29 Thread Aleksandr Parfenov
On Tue, 28 Aug 2018 12:40:32 +0700 Aleksandr Parfenov wrote: >On Fri, 24 Aug 2018 18:50:38 +0300 >Alexander Korotkov wrote: >>Agreed, backward compatibility is important here. Probably we should >>leave old dictionaries for that. But I just meant that if we >>introduce new (better) way of stop

Re: Flexible configuration for full-text search

2018-08-27 Thread Aleksandr Parfenov
On Fri, 24 Aug 2018 18:50:38 +0300 Alexander Korotkov wrote: >Agreed, backward compatibility is important here. Probably we should >leave old dictionaries for that. But I just meant that if we >introduce new (better) way of stop words handling and encourage users >to use it, then it would look s

Re: Flexible configuration for full-text search

2018-08-24 Thread Alexander Korotkov
On Fri, Aug 24, 2018 at 1:13 AM Tom Lane wrote: > Alexander Korotkov writes: > > On Fri, Apr 6, 2018 at 10:52 AM Aleksandr Parfenov > > wrote: > >> The key point of the patch is to process stopwords the same way as > >> others at the level of the PostgreSQL internals and give users an > >> instr

Re: Flexible configuration for full-text search

2018-08-23 Thread Tom Lane
Alexander Korotkov writes: > On Fri, Apr 6, 2018 at 10:52 AM Aleksandr Parfenov > wrote: >> The key point of the patch is to process stopwords the same way as >> others at the level of the PostgreSQL internals and give users an >> instrument to process them in a special way via configurations. >

Re: Flexible configuration for full-text search

2018-08-23 Thread Alexander Korotkov
On Fri, Apr 6, 2018 at 10:52 AM Aleksandr Parfenov wrote: > On Thu, 5 Apr 2018 17:26:10 +0300 > Teodor Sigaev wrote: > > 4) Initial approach suggested to distinguish three state of > > dictionary result: null (unknown word), stopword and usual word. Now > > only two, we lost possibility to catch

Re: Flexible configuration for full-text search

2018-07-20 Thread Alexander Korotkov
Hi, Aleksandr! On Mon, Jul 9, 2018 at 10:26 AM Aleksandr Parfenov < a.parfe...@postgrespro.ru> wrote: > A new version of the patch in the attachment. There are no changes since > the last version except refreshing it to current HEAD. > I took a look at this patch. It applied cleanly, but didn't

Re: Flexible configuration for full-text search

2018-04-05 Thread Andres Freund
Hi, On 2018-04-05 17:26:10 +0300, Teodor Sigaev wrote: > Some notices: > > 0) patch conflicts with last changes in gram.y, conflicts are trivial. > > 1) jsonb in catalog. I'm ok with it, any opinions? > > 2) pg_ts_config_map.h, "jsonb mapdicts" isn't decorated with #ifdef > CATALOG_VARLEN

Re: Flexible configuration for full-text search

2018-04-05 Thread Teodor Sigaev
Some notices: 0) patch conflicts with last changes in gram.y, conflicts are trivial. 1) jsonb in catalog. I'm ok with it, any opinions? 2) pg_ts_config_map.h, "jsonb mapdicts" isn't decorated with #ifdef CATALOG_VARLEN like other varlena columns in catalog. It it's right, pls, explain a

Re: Flexible configuration for full-text search

2018-03-30 Thread Aleksander Alekseev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed LGTM. The new status of this patch is: Ready for Committer

Re: Flexible configuration for full-text search

2018-03-05 Thread Aleksander Alekseev
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Unfortunately this patch doesn't apply anymore: http://commitfest.cputube.org

Re: Flexible configuration for full-text search

2018-01-23 Thread Aleksander Alekseev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed This patch seems to be in a pretty good shape. There is a roo